Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Support for authentication Service principal #56

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

nomtrosk
Copy link

@nomtrosk nomtrosk commented Feb 18, 2025

This first draft is to get early feedback on the approach to support Service Principal Authentication

  • In config.ex we determine which type of autentication the user has chosen
  • The selected method is used via the Auth module which is to replace the SharedKey.sign function everywhere
  • Introduced an azure_integration test tag that will test against the real azure blob storage

TODO:

  • Replace all SharedKey.sign with Auth.authorize_request
  • Cache the bearer token
  • More tests
  • Add typespecs and add doc attributes

This first draft is to get early feedback on the approach to support Service Principal Aauthentication

 * In config.ex we determine which type of autentication the user has choosen
 * The selected method is used via the Auth module which is to replace the SharedKey.sign function everywhere
 * Introduced an azure_integration test tag that will test against the real azure blob stoage
@nomtrosk nomtrosk marked this pull request as draft February 18, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant