Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jc prototype #17

Merged
merged 7 commits into from
Oct 1, 2020
Merged

Jc prototype #17

merged 7 commits into from
Oct 1, 2020

Conversation

jcolomb
Copy link
Member

@jcolomb jcolomb commented Sep 16, 2020

I worked the requirement and added a first prototype for discussion.

For simplicity, I propose to keep affilliation outside of the author entries and refer to them, in all cases. While this makes the information about one author less portable, it will facilitates the work of pandoc (@tarleb ?).

For groups, I would propose to link people to groups via a part.of.group entry and use the author type to deal with it:
author type = author (normal), group (this is the name of a group of authors), non-byline-author (author belonging to a group), non-author-contributor (people normally ending in the aknowledgements)

@jcolomb
Copy link
Member Author

jcolomb commented Sep 16, 2020

NB: the example is better yaml formatted but the idea is the same.

Copy link

@nathanlesage nathanlesage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting approach, and thank you for this initial work! I had some more ideas now that I see one of these yaml blocks "in action". Your thoughts?

@crsh
Copy link
Contributor

crsh commented Sep 22, 2020

Thanks for putting this together, Julien. As a general remark: I think it may be useful to also suggest and discuss which fields are optional and what possible default values could be. For example, I would suggest to let the type attribute default to author and string-name to a given-names + surnames and so on. Where would be a good place to list/discuss these suggestions?

@crsh
Copy link
Contributor

crsh commented Sep 22, 2020

One other thought: There seem to be some redundancies in the affiliation information. Do we need a country field in addition to the ISO 3166-1 alpha-2 code in country.code? Also would it make sense to add a field for postal address (e.g. street) so that this information can be omitted from the name?

@jcolomb
Copy link
Member Author

jcolomb commented Sep 22, 2020

About country fields: this is taken directly from jats4r: they probably have their reasons (?), although I like the postal adress idea.

I would keep a discussion about required fields and default values to a later point, but you are welcome to open a different issue to talk about it.

@jcolomb
Copy link
Member Author

jcolomb commented Oct 1, 2020

moved every comment into issue, PR could be accepted.

@jcolomb jcolomb merged commit 15d4a7f into master Oct 1, 2020
@jcolomb jcolomb deleted the JC_prototype branch October 1, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants