Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #822 - Call Events Early media call status #831

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

surajshivkumar
Copy link
Collaborator

@surajshivkumar surajshivkumar commented Jul 25, 2024

Fix for #822 :

You should now be able to see a call status event to indicate early media playing

Sample from my test call while recreating this issue

{
      "type": "call:status",
      "msgid": "xxxx",
      "call_sid": "xxx",
      "data": {
        "call_sid": "xxxxx",
        "direction": "inbound",
        "from": "xxxx",
        "to": "xxxxx",
        "call_id": "xxxxx",
        "sip_status": 183,
        "sip_reason": "Early Media",
        "account_sid": "xxxxx",
        "trace_id": "xxxxx",
        "application_sid": "xxxxx",
        "fs_sip_address": "xxxx",
        "originating_sip_ip": "xxxxx",
        "api_base_url": "xxxxx"
      }

@davehorton
Copy link
Contributor

generally we want all PRs to reference an issue. In this case we have not created an issue yet, but please create an issue describing the problem

@surajshivkumar surajshivkumar changed the title Call Events - Early media call status Fixes #822 - Call Events Early media call status Jul 25, 2024
@surajshivkumar surajshivkumar linked an issue Jul 25, 2024 that may be closed by this pull request
@sammachin
Copy link

While this looks like a useful event to be sending its not really solving the issue I raised as the event I'm interested in is where the caller hangs up the call during early media

@xquanluu
Copy link
Contributor

Hi @sammachin

while testing this issue, we found that if the call is hangup by caller, jambonz will sent event NoAnswer, sip reason is Request Terminated.

This is correct behavior, please let us know if you was not received this event. If no, please attach a log here.

this._notifyCallStatusChange({
callStatus: CallStatus.NoAnswer,
sipStatus: 487,
sipReason: 'Request Terminated'
});
if (wasEarlyMedia) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this event. Please consider to remove it.

NoAnswer is already good enoug as it's final status as same as Completed

@sammachin
Copy link

Hi @sammachin

while testing this issue, we found that if the call is hangup by caller, jambonz will sent event NoAnswer, sip reason is Request Terminated.

This is correct behavior, please let us know if you was not received this event. If no, please attach a log here.

Thats what I would have expected but not the behcaviour I saw, have a look at #822 for details of a call on jambonz.cloud with the issue.

@surajshivkumar
Copy link
Collaborator Author

@sammachin Could you kindly supply us with another example, or reproduce the same example and provide us with the callsid where you are experiencing the problem?

@sammachin
Copy link

Sure, call sid 7b2165d5-2f56-4553-8472-620adea9980f at 08:08:49 UTC on 2nd August

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Call Events if caller hangs up before answer
4 participants