Make python side of Hourai recognize admins as mods #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rust side of Hourai recognizes anyone with a role that begins with "mod" or "admin" to be a moderator. The python side was never updated to recognize the "admin" prefix. This commit fixes this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rust side of Hourai recognizes anyone with a role that begins with "mod" or "admin" to be a moderator. The python side was never updated to recognize the "admin" prefix. This PR fixes this.
Summary
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
If people are relying on the broken behavior where the python half of the bot doesn't recognize admins as moderators, then it's a breaking change. I don't think that's commonplace, or a good idea though.