Replace notification when resulting collection is not empty in ReplaceRange method

[simusr2]

When resulting collection is not empty Replace notification should be raised instead of Reset.

[ahoke-cr]

@jamesmontemagno would you consider this change? The Reset event is not accurate when replacing the existing items with a new collection of items.

[jamesmontemagno]

I need to think about this because the ReplaceRange is literally clearing it and adding the new items, which is a reset of the collection.

According to the documentaiton Reset should be called when it is cleared and then Replace should be called when an actual item was replaced... so like item[3] = newitem.

So i dont' think this logic is correct.

I could see doing a Reset when I clear it and then a Add when I add items, but how I have it today when You clear and add the range in it's place a Reset is correct as it is resetting the collection.....

[ahoke-cr]

Reset should be called when it is cleared and then Replace should be called when an actual item was replaced

Then the committed changes conform to this, no?

[jamesmontemagno]

Well I think replace is when a single item or other item is replaced in a specific order. I need to read some docs. Really my method is a Reset method, not a replace, as a replace is a single item. I need to read the docs, I am not sure what impact would have on current apps. I also don't know what the issue is today with using Reset, that wasn't described in the PR.