Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update to latest embassy-time, embassy-executor. #76

Merged
merged 10 commits into from
Jan 24, 2025
Merged

chore: update to latest embassy-time, embassy-executor. #76

merged 10 commits into from
Jan 24, 2025

Conversation

pperanich
Copy link
Contributor

Updated to embassy-time 0.4 and embassy-executor 0.7. All postcard-rpc-tests pass.

@jamesmunns
Copy link
Owner

Thank you for the PR! I probably need to look into splitting the impls out of postcard-rpc, potentially into another crate. I'm not certain, but this likely would be considered a breaking change, as it affects the server impls provided by the embassy-usb v0.3 feature.

Let me think about what I need to do about this, if I haven't gotten back to this in ~a week I'll just merge and bump the minor version number :)

@i509VCB
Copy link

i509VCB commented Jan 10, 2025 •
edited
Loading

I tried building this using the pull request's git repo as the source for postcard-rpc and it seems like there are a bunch of errors about:
the trait bound `D: embassy_usb::embassy_usb_driver::Driver<'_>` is not satisfied without using postcard-rpc in a single line of code.

I have verified and it seems that I am using the same git rev for all the embassy crates as your pull request:

https://gist.github.com/i509VCB/f77cf4bfab11f1a509dcf0e8f49cc5de

Compile errors:
https://gist.github.com/i509VCB/e037f2158419986cffc7cc398628c342

bugadani and others added 9 commits January 13, 2025 21:57
@bugadani
Fix deprecation messages (jamesmunns#77)
c0dbfbc
@kzdnk
docs: fix broken link and typos (jamesmunns#78)
dbb5358
@bugadani
Suppress warnings when the client has been stopped (jamesmunns#80)
0c94838
@bugadani
Undeprecate solo subscribers, implement backpressure with timeout (ja…
d198b85 
…mesmunns#82)

* Undeprecate subscribe, add subscribe_exclusive

* Add new_with_wire_and_config

* Add subscriber_timeout_if_full configuration

* Allow replacing closed channels

* Split inner functions
@hvraven
Implement conversion from VarSeq and relax equality comparison (jam…
78ca1a5 
…esmunns#66)

* implement conversion of VarSeq to u8, u16, u32

* change varseq equality to compare key numbers

this adds a manual implementation of `PartialEq` to treat different
variants with the same key value as equal.

Previously `VarSeq::Seq1(1) != VarSeq::Seq2(1)`, with this change they
are treated as equal.

* add simple unit tests for varseq conversion

---------

Co-authored-by: Hendrik v. Raven <[email protected]>
@jamesmunns
Cleanup some misc items
493a058
@jamesmunns
Bump version
f0a15a4
@jamesmunns
Merge branch 'update-embassy-time'
c5d274a
@jamesmunns
Explicitly support embassy-usb v0.4
0854dc8
@jamesmunns
Copy link
Owner

jamesmunns commented Jan 24, 2025 •
edited
Loading

@i509VCB it's likely you also updated to embassy-usb v0.4, where previously we only supported v0.3. I've just pushed an update adding support for v0.4, and added separate checks for both v0.3 and v0.4 support.

I've also run this against cargo-semver-checks, which had no complaints, so I plan to release this as-is shortly!

@jamesmunns jamesmunns merged commit 891213d into jamesmunns:main Jan 24, 2025
1 check passed
@jamesmunns
Copy link
Owner

released as v0.11.5, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pperanich @jamesmunns @i509VCB @bugadani @kzdnk @hvraven