Suppress warnings when the client has been stopped #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmunns
added a commit
that referenced
this pull request
Jan 24, 2025
* chore: update to latest embassy-time, embassy-executor. * Fix deprecation messages (#77) * docs: fix broken link and typos (#78) * Suppress warnings when the client has been stopped (#80) * Undeprecate solo subscribers, implement backpressure with timeout (#82) * Undeprecate subscribe, add subscribe_exclusive * Add new_with_wire_and_config * Add subscriber_timeout_if_full configuration * Allow replacing closed channels * Split inner functions * Implement conversion from `VarSeq` and relax equality comparison (#66) * implement conversion of VarSeq to u8, u16, u32 * change varseq equality to compare key numbers this adds a manual implementation of `PartialEq` to treat different variants with the same key value as equal. Previously `VarSeq::Seq1(1) != VarSeq::Seq2(1)`, with this change they are treated as equal. * add simple unit tests for varseq conversion --------- Co-authored-by: Hendrik v. Raven <[email protected]> * Cleanup some misc items * Bump version * Explicitly support embassy-usb v0.4 --------- Co-authored-by: Dániel Buga <[email protected]> Co-authored-by: kzdnk <[email protected]> Co-authored-by: Hendrik v. Raven <[email protected]> Co-authored-by: Hendrik v. Raven <[email protected]> Co-authored-by: James Munns <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the client is dropped, tokio can poll the
select!-ed futures in a random order, and the client implementation can emit warnings if the WireRx, or the internal receiver are polled before the stopper is.This PR ensures the cancel future is polled first, which doesn't let the streams run into errors if the client is
stopped before dropping it.