Skip to content

Commit

Permalink
chore: Remove generated compose files and extend existing override
Browse files Browse the repository at this point in the history
Signed-off-by: Alf-Rune Siqveland <[email protected]>
  • Loading branch information
alfrunes committed Oct 29, 2024
1 parent d0f2be6 commit 4ff7fcc
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 26 deletions.
1 change: 1 addition & 0 deletions extra/integration-testing/docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@

services:
mender-api-gateway:
ports: !reset []
environment:
TESTING: "true"
3 changes: 3 additions & 0 deletions storage-proxy/docker-compose.storage-proxy.testing.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
services:
storage-proxy:
ports: !reset []
27 changes: 2 additions & 25 deletions tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,30 +56,6 @@ def pytest_addoption(parser):
)


def _remove_ports(file, output_file):
with open(file, "r") as f, open(output_file, "w") as out:
file = yaml.safe_load(f)
for key in file["services"]:
services = file["services"][key]
if services.get("ports", False):
del services["ports"]
yaml.safe_dump(file, out, sort_keys=False)


@pytest.fixture(scope="session", autouse=True)
def modify_compose_for_testing(request):
demo = "../docker-compose.demo.yml"
storage_proxy_demo = "../storage-proxy/docker-compose.storage-proxy.demo.yml"
# Output files after modifying for testing
testing = "../docker-compose.testing.yml"
storage_proxy_testing = "../storage-proxy/docker-compose.storage-proxy.testing.yml"

# Remove published ports from docker-compose-demo
_remove_ports(demo, testing)
# Remove published ports from docker-compose.storage-proxy.demo
_remove_ports(storage_proxy_demo, storage_proxy_testing)


def _extract_fs_from_image(request, client_compose_file, filename):
if os.path.exists(os.path.join(THIS_DIR, filename)):
return filename
Expand All @@ -97,7 +73,8 @@ def _extract_fs_from_image(request, client_compose_file, filename):
"config",
"--images",
image_type,
]
],
env=os.environ,
)
.decode("UTF-8")
.strip()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class DockerComposeNamespace(DockerComposeBaseNamespace):
BASE_FILES = [
COMPOSE_FILES_PATH + "/docker-compose.yml",
COMPOSE_FILES_PATH + "/docker-compose.storage.minio.yml",
COMPOSE_FILES_PATH + "/docker-compose.testing.yml",
COMPOSE_FILES_PATH + "/docker-compose.demo.yml",
COMPOSE_FILES_PATH + "/extra/integration-testing/docker-compose.yml",
]
QEMU_CLIENT_FILES = [
Expand Down

0 comments on commit 4ff7fcc

Please sign in to comment.