Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mapping tests to playwright #257

Merged
merged 3 commits into from
Mar 30, 2024

Conversation

janechu
Copy link
Owner

@janechu janechu commented Mar 30, 2024

Pull Request

πŸ“– Description

This change makes no functionality changes, but converts an unused deprecated jest test to playwright.

🎫 Issues

Continues work on #133

πŸ‘©β€πŸ’» Notes

One file was converted from .tsx to .ts.

βœ… Checklist

General

  • I have added tests which has increased test coverage.
  • I have made visual changes.
    • I am on MacOS and have added or updated snapshots.
    • I am not on MacOS and have provided a screenshot in the notes section.
  • I have updated the project documentation to reflect my changes.

@janechu janechu self-assigned this Mar 30, 2024
@janechu janechu changed the title Users/janechu/update mapping tests to playwright Update mapping tests to playwright Mar 30, 2024
Copy link

LCOV of commit 453c625 during Validate Coverage #39

Summary coverage rate:
  lines......: 65.6% (1371 of 2091 lines)
  functions..: 74.7% (470 of 629 functions)
  branches...: 55.2% (548 of 993 branches)

Files changed coverage rate: n/a

design-to-code

Copy link

LCOV of commit 886036d during Validate Coverage #40

Summary coverage rate:
  lines......: 65.6% (1371 of 2091 lines)
  functions..: 74.7% (470 of 629 functions)
  branches...: 55.2% (548 of 993 branches)

Files changed coverage rate: n/a

design-to-code

Copy link

LCOV of commit 886036d during Validate Coverage #40

Summary coverage rate:
  lines......: 51.6% (740 of 1434 lines)
  functions..: 53.1% (243 of 458 functions)
  branches...: 40.1% (358 of 892 branches)

Files changed coverage rate: n/a

design-to-code-react

@janechu janechu merged commit d86312f into main Mar 30, 2024
2 of 3 checks passed
@janechu janechu deleted the users/janechu/update-mapping-tests-to-playwright branch March 30, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant