Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for being unable to read root group of hdf5 #84

Closed

Conversation

neptunes5thmoon
Copy link
Contributor

Currently reading an hdf5 file directly, i.e. read("myfile.h5") throws an error:
ValueError: Unable to synchronously create group (name parameter cannot be an empty string)
I expect it to return the HDF5 group at the file's root.

This PR:

  • adds testing for the above
  • changes tests for other file formats to use access from core (so that it's before path splitting)
  • changes split_by_suffix to return "/" as the subpath if the path ends in one of the known suffixes
  • changes the test for path splitting to account for the change in behavior

@d-v-b
Copy link
Contributor

d-v-b commented Sep 13, 2024

Naming the root group "/" is funny behavior from hdf5 -- "/" is not the name of any node but rather the separator character used to join node names, and thus the empty string "" is the "real" name of the root group. I think we can handle this quirk in the hdf5 reading logic, instead of higher up in the stack. I will get a PR shortly that does this.

@neptunes5thmoon
Copy link
Contributor Author

closing in favor of #85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants