Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clojure.core loads twice #175

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: clojure.core loads twice #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions compiler+runtime/src/cpp/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ namespace jank
throw std::runtime_error{ "Not yet implemented: REPL server" };
}

if(opts.target_module != "clojure.core")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary? If we try to load_module clojure.core twice, it should already be loaded the second time and do nothing, right?

{
profile::timer const timer{ "require clojure.core" };
__rt_ctx->load_module("/clojure.core", module::origin::latest).expect_ok();
Expand Down
2 changes: 0 additions & 2 deletions compiler+runtime/src/jank/clojure/core.jank
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7412,5 +7412,3 @@ fails, attempts to require sym's namespace and retries."
[#_double num]
;; (Double/isInfinite num)
(throw "TODO: port"))

(println "Bottom of clojure.core")
Loading