Updated netspeed widget #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bats tests may be run as part of the PR workflow if #70 gets implemented. That PR additionally fixes the shfmt pre-commit to use a newer version that supports Bats files. |
Stealthii
force-pushed
the
feature/netspeed
branch
3 times, most recently
from
f73601e to
b97cc66
Compare
janoamaral
requested changes
Apr 22, 2024
This implements the features suggested in janoamaral#66: - Detect when the interface is down - Add config flag to show local IPv4 address - Updated icons for interface types and state The following additional changes were implemented: - Reduce to single bc calls for netspeed calculations - Add interface auto-detection via route - Add variable refresh time
This implements BATS tests for functions provided by the netspeed library where possible, as well as fixing two edge cases discovered whilst testing.
This should improve detection of wireless devices.
Added snapshot and new configuration options.
Stealthii
force-pushed
the
feature/netspeed
branch
from
b97cc66 to
be58661
Compare
|
PR rebased, icons and screenshot updated! |
janoamaral
approved these changes
Apr 22, 2024
uNyanda
pushed a commit
to uNyanda/tokyo-night-tmux
that referenced
this pull request
Nov 13, 2024
## Minor changes - [X] netspeed: auto-detect interface if undefined - [X] netspeed: new widget icons for device class and state - [X] netspeed: detect interface type (wired/wireless) - [X] netspeed: detect interface online state - [X] netspeed: show IPv4 address with the `@tokyo-night-tmux_netspeed_showip` option - [X] netspeed: vary the refresh rate with the `@tokyo-night-tmux_netspeed_refresh` option ## Bug & security fixes - [X] netspeed: improve accuracy and performance of netspeed calculations with `bc` - [X] netspeed: handle - [X] netspeed: handle VPN devices on macOS using the primary interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the features suggested in #66:
The following additional changes were implemented:
Up, with traffic and IP:
Down:
BATS tests have been added to validate functionality, with a few edge cases handled that were discovered during testing.
Minor changes
@tokyo-night-tmux_netspeed_showipoption@tokyo-night-tmux_netspeed_refreshoptionBug & security fixes
bcAdditional information
Potentially resolves #66.