chore(cli): update error message (#2571)

This change updates the error message produced by the native replacement package to make it clear that native modules are not currently supported. This change also includes two small fixes suggested by sonarqube. Signed-off-by: Stan Lewis <[email protected]>
janus-idp · Dec 4, 2024 · 99d3145 · 99d3145
1 parent 2acb6e0
commit 99d3145
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 15 deletions.
diff --git a/.changeset/grumpy-bulldogs-sit.md b/.changeset/grumpy-bulldogs-sit.md
@@ -0,0 +1,2 @@
+---
+---
diff --git a/packages/cli/src/commands/export-dynamic-plugin/backend-embed-as-dependencies.ts b/packages/cli/src/commands/export-dynamic-plugin/backend-embed-as-dependencies.ts
@@ -141,7 +141,7 @@ ${
         path.join(target, 'embedded', toSuppress, 'index.js'),
         `
 throw new Error(
-  'The package "${toSuppress}" has been marked as a native module and removed from this dynamic plugin package "${derivedPackageName}"'
+  'The package "${toSuppress}" has been marked as a native module and removed from this dynamic plugin package "${derivedPackageName}", as native modules are not currently supported by dynamic plugins'
 );`,
       );
     }
@@ -233,11 +233,15 @@ throw new Error(
     })(path.join(embeddedDestDir, 'package.json'));
   }
 
-  const embeddedDependenciesResolutions: { [key: string]: any } = {};
-  embeddedResolvedPackages.map(ep => {
-    embeddedDependenciesResolutions[ep.packageName] =
-      `file:./${embeddedPackageRelativePath(ep)}`;
-  });
+  const embeddedDependenciesResolutions = embeddedResolvedPackages.reduce(
+    (resolutions, embeddedPkg) => ({
+      ...resolutions,
+      ...{
+        [embeddedPkg.packageName]: `file:./${embeddedPackageRelativePath(embeddedPkg)}`,
+      },
+    }),
+    {},
+  );
 
   if (opts.build) {
     Task.log(`Building main package`);

diff --git a/packages/cli/src/commands/export-dynamic-plugin/backend-utils.ts b/packages/cli/src/commands/export-dynamic-plugin/backend-utils.ts
@@ -89,16 +89,16 @@ export function addToMainDependencies(
         Task.log(
           `The version of a dependency ('${dep}') of an embedded module differs from the main module's dependencies: '${dependenciesToAdd[dep]}', '${existingVersion}': keeping it as it is compatible`,
         );
+        continue;
+      }
+      if (ignoreVersionCheck.includes(dep)) {
+        Task.log(
+          `The version of a dependency ('${dep}') of an embedded module conflicts with the main module's dependencies: '${dependenciesToAdd[dep]}', '${existingVersion}': however this has been overridden`,
+        );
       } else {
-        if (!ignoreVersionCheck.includes(dep)) {
-          throw new Error(
-            `The version of a dependency ('${dep}') of an embedded module conflicts with main module dependencies: '${dependenciesToAdd[dep]}', '${existingVersion}': cannot proceed!`,
-          );
-        } else {
-          Task.log(
-            `The version of a dependency ('${dep}') of an embedded module conflicts with the main module's dependencies: '${dependenciesToAdd[dep]}', '${existingVersion}': however this has been overridden`,
-          );
-        }
+        throw new Error(
+          `The version of a dependency ('${dep}') of an embedded module conflicts with main module dependencies: '${dependenciesToAdd[dep]}', '${existingVersion}': cannot proceed!`,
+        );
       }
     }
   }