fix(cli): extend --ignore-version-check [release-1.4] #2619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the cli's --ignore-version-check flag to also ignore the check performed on a embedded transitive dependencies that are moved to peer dependencies, when it is known that the mismatch is runtime compatible. Signed-off-by: Stan Lewis <[email protected]>
openshift-cherrypick-robot
requested review from
davidfestal,
jesuino,
gashcrumb,
kadel and
a team
as code owners
🦋 Changeset detectedLatest commit: 949e8b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
nickboldt
changed the title
kadel
approved these changes
Jan 21, 2025
|
Stan said:
y'all should just mash the merge button or add the |
|
I reviewed this, it look ok. But than I realized that I don't fully understand how the backporting is supposed to work with plugins 😇 So I got scared and removed the lgtm label :-D |
|
But now I undertsand it as I see #2621 correctly pusghing new 1.18.x version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #2616
/assign gashcrumb