Skip to content

Commit

Permalink
pkp/pkp-lib#10685 Clean up translation duplicates
Browse files Browse the repository at this point in the history
  • Loading branch information
jardakotesovec committed Dec 11, 2024
1 parent 88080f2 commit 3809af7
Show file tree
Hide file tree
Showing 13 changed files with 46 additions and 46 deletions.
12 changes: 6 additions & 6 deletions src/composables/useSubmission.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@ export const ExtendedStages = {

export const ExtendedStagesLabels = {
incomplete: tk('submissions.incomplete'),
submission: tk('dashboard.stage.submission'),
submission: tk('manager.publication.submissionStage'),
internalReview: tk('todo'),
externalReview: tk('dashboard.stage.reviewWithRound'),
editing: tk('dashboard.stage.copyediting'),
productionQueued: tk('dashboard.stage.production'),
productionScheduled: tk('dashboard.stage.scheduledForPublication'),
productionPublished: tk('dashboard.stage.published'),
externalReview: tk('submission.stage.externalReviewWithRound'),
editing: tk('submission.copyediting'),
productionQueued: tk('manager.publication.productionStage'),
productionScheduled: tk('submission.dashboard.view.scheduled'),
productionPublished: tk('submission.dashboard.view.published'),
declined: tk('submissions.declined'),
};

Expand Down
28 changes: 14 additions & 14 deletions src/managers/FileManager/useFileManagerConfig.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ export const FileManagerConfigurations = {
Actions.FILE_SEE_NOTES,
],
fileStage: pkp.const.SUBMISSION_FILE_SUBMISSION,
titleKey: tk('dashboard.summary.deskReviewFiles'),
descriptionKey: tk('dashboard.summary.deskReviewFilesDescription'),
titleKey: tk('submission.submit.submissionFiles'),
descriptionKey: tk('fileManager.submissionFilesDescription'),
wizardTitleKey: tk('submission.submit.uploadSubmissionFile'),
}),
EDITOR_REVIEW_FILES: ({stageId}) => ({
Expand Down Expand Up @@ -75,8 +75,8 @@ export const FileManagerConfigurations = {
? pkp.const.SUBMISSION_FILE_INTERNAL_REVIEW_FILE
: pkp.const.SUBMISSION_FILE_REVIEW_FILE,
gridComponent: 'grid.files.review.EditorReviewFilesGridHandler',
titleKey: tk('dashboard.summary.filesForReview'),
descriptionKey: tk('dashboard.summary.deskReviewFilesDescription'),
titleKey: tk('fileManager.filesForReview'),
descriptionKey: tk('fileManager.submissionFilesDescription'),
uploadSelectTitleKey: tk('editor.submission.review.currentFiles'),
}),
WORKFLOW_REVIEW_REVISIONS: ({stageId}) => ({
Expand Down Expand Up @@ -117,8 +117,8 @@ export const FileManagerConfigurations = {
stageId === pkp.const.WORKFLOW_STAGE_ID_INTERNAL_REVIEW
? pkp.const.SUBMISSION_FILE_INTERNAL_REVIEW_REVISION
: pkp.const.SUBMISSION_FILE_REVIEW_REVISION,
titleKey: tk('dashboard.summary.revisionsUploaded'),
descriptionKey: tk('dashboard.summary.revisionsUploadedDescription'),
titleKey: tk('submission.list.revisionsSubmitted'),
descriptionKey: tk('fileManager.revisionsUploadedDescription'),
wizardTitleKey: tk('editor.submissionReview.uploadFile'),
}),
// TODO after triage
Expand All @@ -128,8 +128,8 @@ export const FileManagerConfigurations = {
actions: [],
fileStage: pkp.const.SUBMISSION_FILE_REVIEW_ATTACHMENT,
gridComponent: 'grid.files.attachment.authorReviewAttachmentsGridHandler',
titleKey: tk('dashboard.summary.filesForReview'),
descriptionKey: tk('dashboard.summary.deskReviewFilesDescription'),
titleKey: tk('fileManager.filesForReview'),
descriptionKey: tk('fileManager.deskReviewFilesDescription'),
uploadSelectTitleKey: tk('editor.submission.review.currentFiles'),
}),
COPYEDITED_FILES: ({stageId}) => ({
Expand Down Expand Up @@ -162,8 +162,8 @@ export const FileManagerConfigurations = {
Actions.FILE_SEE_NOTES,
],
fileStage: pkp.const.SUBMISSION_FILE_COPYEDIT,
titleKey: tk('dashboard.summary.copyeditedFiles'),
descriptionKey: tk('dashboard.summary.copyeditedFilesDescription'),
titleKey: tk('fileManager.copyeditedFiles'),
descriptionKey: tk('fileManager.copyeditedFilesDescription'),
gridComponent: 'grid.files.copyedit.CopyeditFilesGridHandler',
uploadSelectTitleKey: tk('editor.submissionReview.uploadFile'),
}),
Expand Down Expand Up @@ -193,8 +193,8 @@ export const FileManagerConfigurations = {
Actions.FILE_SEE_NOTES,
],
fileStage: pkp.const.SUBMISSION_FILE_FINAL,
titleKey: tk('dashboard.summary.draftFiles'),
descriptionKey: tk('dashboard.summary.draftFilesDescription'),
titleKey: tk('submission.finalDraft'),
descriptionKey: tk('fileManager.draftFilesDescription'),
gridComponent: 'grid.files.final.FinalDraftFilesGridHandler',
uploadSelectTitleKey: tk('editor.submission.uploadSelectFiles'),
}),
Expand Down Expand Up @@ -224,8 +224,8 @@ export const FileManagerConfigurations = {
Actions.FILE_SEE_NOTES,
],
fileStage: pkp.const.SUBMISSION_FILE_PRODUCTION_READY,
titleKey: tk('dashboard.summary.productionReadyFiles'),
descriptionKey: tk('dashboard.summary.productionReadyFilesDescription'),
titleKey: tk('editor.submission.production.productionReadyFiles'),
descriptionKey: tk('fileManager.productionReadyFilesDescription'),
wizardTitleKey: tk('submission.upload.productionReady'),
}),
};
Expand Down
2 changes: 1 addition & 1 deletion src/managers/ParticipantManager/ParticipantManager.vue
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
v-if="participant.recommendOnly"
class="mt-0.5 text-xs-normal text-heading"
>
{{ t('dashboard.recommendOnly.onlyAllowedToRecommend') }}
{{ t('participantManager.onlyAllowedToRecommend') }}
</div>
</div>
</div>
Expand Down
6 changes: 3 additions & 3 deletions src/managers/ReviewerManager/ReviewerManager.vue
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
>
<template #label>
<h3 class="">
{{ t('dashboard.summary.reviewers') }}
{{ t('user.role.reviewers') }}
</h3>
</template>
<template #top-controls>
Expand All @@ -21,9 +21,9 @@
</div>
</template>
<TableHeader>
<TableColumn>{{ t('dashboard.summary.reviewer') }}</TableColumn>
<TableColumn>{{ t('user.role.reviewer') }}</TableColumn>
<TableColumn>
{{ t('dashboard.summary.reviewerStatus') }}
{{ t('reviewerManager.reviewerStatus') }}
</TableColumn>
<TableColumn>{{ t('common.type') }}</TableColumn>
<TableColumn>{{ t('grid.columns.actions') }}</TableColumn>
Expand Down
6 changes: 3 additions & 3 deletions src/pages/dashboard/composables/useEditorialLogic.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export function useEditorialLogic() {
component: 'CellSubmissionActivityActionAlert',
props: {
actionName: ParticipantManagerActions.PARTICIPANT_ASSIGN,
actionLabel: t('dashboard.assignEditor'),
actionLabel: t('submission.list.assignEditor'),
actionArgs: {submissionId: submission.id},
},
},
Expand Down Expand Up @@ -100,7 +100,7 @@ export function useEditorialLogic() {
{
component: 'CellSubmissionActivityActionAlert',
props: {
alert: t('dashboard.revisionsSubmitted'),
alert: t('submission.list.revisionsSubmitted'),
},
},
{
Expand Down Expand Up @@ -158,7 +158,7 @@ export function useEditorialLogic() {
{
component: 'CellSubmissionActivityActionAlert',
props: {
alert: t('dashboard.revisionsSubmitted'),
alert: t('submission.list.revisionsSubmitted'),
},
},
{
Expand Down
6 changes: 3 additions & 3 deletions src/pages/dashboard/dashboardPageStore.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ import DashboardModalFilters from '@/pages/dashboard/modals/DashboardModalFilter
const {t, tk} = useLocalize();

const TitleTranslations = {
editorialDashboard: tk('dashboard.dashboards'),
myReviewAssignments: tk('dashboard.reviewAssignments'),
mySubmissions: tk('dashboard.mySubmissions'),
editorialDashboard: tk('navigation.dashboards'),
myReviewAssignments: tk('navigation.reviewAssignments'),
mySubmissions: tk('navigation.mySubmissions'),
};

const TitleIcons = {
Expand Down
2 changes: 1 addition & 1 deletion src/pages/dashboard/modals/DashboardModalFilters.vue
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<div class="bg-secondary p-4">
<div class="mt-4 flex justify-end gap-2">
<PkpButton @click="clearFiltersForm()">
{{ t('dashboard.clearFilters') }}
{{ t('common.filtersClear') }}
</PkpButton>
<PkpButton is-primary="true" @click="applyFilters()">
{{ t('dashboard.applyFilters') }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ export const WorkflowConfig = {
{
component: 'WorkflowActionButton',
props: {
label: t('dashboard.summary.requestRevisions'),
label: t('editor.submission.decision.requestRevisions'),
isSecondary: true,
action: WorkflowActions.WORKFLOW_REQUEST_REVISION,
actionArgs,
Expand Down Expand Up @@ -718,7 +718,7 @@ export const PublicationConfig = {
items.push({
component: 'WorkflowActionButton',
props: {
label: t('dashboard.summary.preview'),
label: t('common.preview'),
isSecondary: true,
action: Actions.WORKFLOW_PREVIEW_PUBLICATION,
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ export const WorkflowConfig = {
{
component: 'WorkflowActionButton',
props: {
label: t('dashboard.summary.requestRevisions'),
label: t('editor.submission.decision.requestRevisions'),
isSecondary: true,
action: DecisionActions.DECISION_PENDING_REVISIONS_INTERNAL,
actionArgs,
Expand Down Expand Up @@ -485,7 +485,7 @@ export const PublicationConfig = {
items.push({
component: 'WorkflowActionButton',
props: {
label: t('dashboard.summary.preview'),
label: t('common.preview'),
isSecondary: true,
action: WorkflowActions.WORKFLOW_PREVIEW_PUBLICATION,
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ export const PublicationConfig = {
items.push({
component: 'WorkflowActionButton',
props: {
label: t('dashboard.summary.preview'),
label: t('common.preview'),
isSecondary: true,
action: WorkflowActions.WORKFLOW_PREVIEW_PUBLICATION,
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export function getReviewItems({submission, stageId, title}) {
export function getReviewItem({stageId, reviewRound, isActive, title}) {
return {
key: `workflow_${stageId}_${reviewRound.id}`,
label: t('dashboard.workflow.reviewRoundN', {number: reviewRound.round}),
label: t('workflow.reviewRoundN', {number: reviewRound.round}),
colorStripe: isActive ? StageColors[stageId] : null,
action: 'selectMenu',
actionArgs: {
Expand All @@ -104,23 +104,23 @@ export function useWorkflowNavigationConfigOJS(pageInitConfig) {
const externalReviewItems = getReviewItems({
submission,
stageId: pkp.const.WORKFLOW_STAGE_ID_EXTERNAL_REVIEW,
title: t('dashboard.stage.review'),
title: t('manager.publication.reviewStage'),
});

const items = [];

items.push(
getWorkflowItem({
stageId: pkp.const.WORKFLOW_STAGE_ID_SUBMISSION,
label: t('dashboard.stage.submission'),
label: t('manager.publication.submissionStage'),
isActive: activeStage.id === pkp.const.WORKFLOW_STAGE_ID_SUBMISSION,
}),
);

items.push(
getWorkflowItem({
stageId: pkp.const.WORKFLOW_STAGE_ID_EXTERNAL_REVIEW,
label: t('dashboard.stage.review'),
label: t('manager.publication.reviewStage'),
isActive:
activeStage.id === pkp.const.WORKFLOW_STAGE_ID_EXTERNAL_REVIEW,
isDisabled: externalReviewItems.length,
Expand All @@ -131,15 +131,15 @@ export function useWorkflowNavigationConfigOJS(pageInitConfig) {
items.push(
getWorkflowItem({
stageId: pkp.const.WORKFLOW_STAGE_ID_EDITING,
label: t('dashboard.stage.copyediting'),
label: t('submission.copyediting'),
isActive: activeStage.id === pkp.const.WORKFLOW_STAGE_ID_EDITING,
}),
);

items.push(
getWorkflowItem({
stageId: pkp.const.WORKFLOW_STAGE_ID_PRODUCTION,
label: t('dashboard.stage.production'),
label: t('manager.publication.productionStage'),
isActive: activeStage.id === pkp.const.WORKFLOW_STAGE_ID_PRODUCTION,
}),
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export function useWorkflowNavigationConfigOMP(pageInitConfig) {
items.push(
getWorkflowItem({
stageId: pkp.const.WORKFLOW_STAGE_ID_SUBMISSION,
label: t('dashboard.stage.submission'),
label: t('manager.publication.submissionStage'),
isActive: activeStage.id === pkp.const.WORKFLOW_STAGE_ID_SUBMISSION,
}),
);
Expand Down Expand Up @@ -86,15 +86,15 @@ export function useWorkflowNavigationConfigOMP(pageInitConfig) {
items.push(
getWorkflowItem({
stageId: pkp.const.WORKFLOW_STAGE_ID_EDITING,
label: t('dashboard.stage.copyediting'),
label: t('submission.copyediting'),
isActive: activeStage.id === pkp.const.WORKFLOW_STAGE_ID_EDITING,
}),
);

items.push(
getWorkflowItem({
stageId: pkp.const.WORKFLOW_STAGE_ID_PRODUCTION,
label: t('dashboard.stage.production'),
label: t('manager.publication.productionStage'),
isActive: activeStage.id === pkp.const.WORKFLOW_STAGE_ID_PRODUCTION,
}),
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export function useWorkflowNavigationConfigOPS(pageInitConfig) {
items.push(
getWorkflowItem({
stageId: pkp.const.WORKFLOW_STAGE_ID_PRODUCTION,
label: t('dashboard.stage.production'),
label: t('manager.publication.productionStage'),
isActive: activeStage.id === pkp.const.WORKFLOW_STAGE_ID_PRODUCTION,
}),
);
Expand Down

0 comments on commit 3809af7

Please sign in to comment.