Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readme strategy options #93

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

readme strategy options #93

wants to merge 2 commits into from

Conversation

dan-nl
Copy link

@dan-nl dan-nl commented Oct 27, 2017

this resolves #28, resolves #46, resolves #57, resolves #91

@coveralls
Copy link

coveralls commented Oct 27, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling db7b564 on dan-nl:feature/readme-strategy-options into a948096 on jaredhanson:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling db7b564 on dan-nl:feature/readme-strategy-options into a948096 on jaredhanson:master.

@dan-nl dan-nl force-pushed the feature/readme-strategy-options branch 2 times, most recently from db59053 to e5813f2 Compare October 27, 2017 21:25
@coveralls
Copy link

coveralls commented Oct 27, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling db59053 on dan-nl:feature/readme-strategy-options into a948096 on jaredhanson:master.

@coveralls
Copy link

coveralls commented Oct 27, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling e5813f2 on dan-nl:feature/readme-strategy-options into a948096 on jaredhanson:master.

@dan-nl dan-nl force-pushed the feature/readme-strategy-options branch 2 times, most recently from 21e9d81 to 57daaf5 Compare October 27, 2017 21:42
@dan-nl dan-nl force-pushed the feature/readme-strategy-options branch from 57daaf5 to e9e133a Compare October 27, 2017 21:44
@coveralls
Copy link

coveralls commented Oct 27, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling e9e133a on dan-nl:feature/readme-strategy-options into a948096 on jaredhanson:master.

@coveralls
Copy link

coveralls commented Oct 27, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 21e9d81 on dan-nl:feature/readme-strategy-options into a948096 on jaredhanson:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 21e9d81 on dan-nl:feature/readme-strategy-options into a948096 on jaredhanson:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 21e9d81 on dan-nl:feature/readme-strategy-options into a948096 on jaredhanson:master.

@coveralls
Copy link

coveralls commented Oct 27, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling e9e133a on dan-nl:feature/readme-strategy-options into a948096 on jaredhanson:master.

joh-klein
joh-klein reviewed Oct 28, 2017
View reviewed changes
README.md Outdated

#### state
OPTIONAL<br>
`{ sessionKey: boolean }`<br>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy/paste bug :) This should say "state"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@coveralls
Copy link

coveralls commented Oct 28, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling a8cda94 on dan-nl:feature/readme-strategy-options into a948096 on jaredhanson:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a8cda94 on dan-nl:feature/readme-strategy-options into a948096 on jaredhanson:master.

@joh-klein joh-klein mentioned this pull request Oct 28, 2017
Open
@rwky
Copy link

rwky commented Jul 7, 2018

Merged in https://github.com/passport-next/passport-oauth2

rwky added a commit to passport-next/passport-oauth2 that referenced this pull request Jul 7, 2018
@rwky
Merge remote-tracking branch 'dan-nl/feature/readme-strategy-options' j…
b6a081f 
…aredhanson#93
@dan-nl dan-nl mentioned this pull request Oct 26, 2018
Open
@MrOrz
Copy link

MrOrz commented Jun 25, 2020

Info in this PR is very valuable, thank you @dan-nl !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joh-klein joh-klein joh-klein left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@dan-nl @coveralls @rwky @MrOrz @joh-klein