-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix value type #3961
base: main
Are you sure you want to change the base?
Fix value type #3961
Conversation
🦋 Changeset detectedLatest commit: e70d2ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
.changeset/khaki-cherries-appear.md
Outdated
@@ -0,0 +1,5 @@ | |||
--- | |||
'formik': major |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is widening a type a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@quantizor I just walk through changeset tutorial.
What should I put in instead of major
? minor
is ok?
Or could you write code suggestion here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think probably just a patch
is ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed it. Could you please check?
Co-authored-by: Evan Jacobs <[email protected]>
Form values can also be number, boolean, especially when you customize the form control.
In React Native, I created a new customized form select and the value is number. In this case, this causes error because
eventOrTextValue.target
oreventOrTextValue.currentTarget
is undefined.Can we fix to support such cases?