Don’t lowercase the test filename. #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test fails if Cosmo builds from a path that contains an uppercase character.
Paths with uppercase characters aren’t so common in server Linux. But they are in *desktop* Linux. Guess how I…?
But I digress.
The real problem is that the path is lowercased on one line, but not the next:
```
self.file_name = support.TESTFN.lower()
self.file_path = FakePath(support.TESTFN)
```
Given that no other test in the suite lowercases `support.TESTFN`, I opted to remove it from the first line rather than adding it to the second.
G4Vi
pushed a commit
to G4Vi/cosmopolitan
that referenced
this pull request
Jan 19, 2024
This test fails if Cosmo builds from a path that contains an uppercase character.
Paths with uppercase characters aren’t so common in server Linux. But they are in *desktop* Linux. Guess how I…?
But I digress.
The real problem is that the path is lowercased on one line, but not the next:
```
self.file_name = support.TESTFN.lower()
self.file_path = FakePath(support.TESTFN)
```
Given that no other test in the suite lowercases `support.TESTFN`, I opted to remove it from the first line rather than adding it to the second.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test fails if Cosmo builds from a path that contains an uppercase character.
Paths with uppercase characters aren’t so common in server Linux. But they are in desktop Linux. Guess how I…?
But I digress.
The real problem is that the path is lowercased on one line, but not the next:
Given that no other test in the suite lowercases
support.TESTFN, I opted to remove it from the first line rather than add it to the second.