Remove clean and set brightness from begin #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Begin method will not clean or change the brightness because on ESP8266 when resuming from deep sleep would create flickering.
smaryus
changed the title
|
I would like to test this on the Arduino Uno and an ATtiny to make sure we don't have unintended side effects. Thanks for submitting this! |
|
Sure, thanks for checking it. |
This is brilliant! I like this! |
The parameter will control if begin needs will clear the display and set the brightness to maximum.
|
Thanks @smaryus ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove clean and set brightness from begin method because on ESP8266 when resuming from deep sleep would create flickering. This is because ESP8266 when it wakes up from deep sleep the device does a restart, which would invoke begin().