-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use arduinoJson for fields #216
Merged
Merged
Commits on Nov 17, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 422e4e3 - Browse repository at this point
Copy the full SHA 422e4e3View commit details
Commits on Nov 20, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 68f7350 - Browse repository at this point
Copy the full SHA 68f7350View commit details -
Configuration menu - View commit details
-
Copy full SHA for 939936e - Browse repository at this point
Copy the full SHA 939936eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2152074 - Browse repository at this point
Copy the full SHA 2152074View commit details
Commits on Nov 22, 2021
-
Use ArduinoJSON to reduce heap fragmentation
Use a pre-allocated DynamicJsonDocument to more easily create the JSON structure. As a nice side effect, it also performs only two allocations: One for the DynamicJsonDocument, One for `result.reserve()` call. The old function had 28 lines of the form: `(String)json += "foo" + (String)bar() + ","` Each line creates three temporary String objects: (e.g., "foo", result from bar()), ","). It then appends "foo" + "bar" (often another allocation), then appends the trailing close-quote and comma (unlikely, but potentially another allocation). Finally, the first temporary variable (now "foo : bar,") is appended to the current final result string (28 allocations).
Configuration menu - View commit details
-
Copy full SHA for a082480 - Browse repository at this point
Copy the full SHA a082480View commit details
Commits on Nov 25, 2021
-
namespace and enum for field type
The anonymous/unnamed namespace ensures no unintended pollution of the global namespace, and makes clear what the external API for this file contains. This makes it much easier to change the underlying implementation, as it's guaranteed that changes internal to the namespace won't break other source files. Use of a scoped enum for field type enables compiler warnings. Specifically, use of a `switch` statement with no `default` case will generate a compiler warning/error if missing any values. Tested to generate 100% identical JSON on Fib256.
Configuration menu - View commit details
-
Copy full SHA for 64d66a1 - Browse repository at this point
Copy the full SHA 64d66a1View commit details -
Add and use JSON converter function for
Field
Confirmed identical JSON output for at least Fib256.
Configuration menu - View commit details
-
Copy full SHA for fc7cd56 - Browse repository at this point
Copy the full SHA fc7cd56View commit details -
arduinoJson used for palettes and patterns
Verified identical JSON output on at least Fib256.
Configuration menu - View commit details
-
Copy full SHA for a5c21e2 - Browse repository at this point
Copy the full SHA a5c21e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63df7f3 - Browse repository at this point
Copy the full SHA 63df7f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca2a307 - Browse repository at this point
Copy the full SHA ca2a307View commit details -
Configuration menu - View commit details
-
Copy full SHA for a18e950 - Browse repository at this point
Copy the full SHA a18e950View commit details
Commits on Nov 26, 2021
-
Configuration menu - View commit details
-
Copy full SHA for c147d83 - Browse repository at this point
Copy the full SHA c147d83View commit details -
Configuration menu - View commit details
-
Copy full SHA for 942a8a6 - Browse repository at this point
Copy the full SHA 942a8a6View commit details
Commits on Nov 27, 2021
-
Configuration menu - View commit details
-
Copy full SHA for ba9c743 - Browse repository at this point
Copy the full SHA ba9c743View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f61d0f - Browse repository at this point
Copy the full SHA 7f61d0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 540693d - Browse repository at this point
Copy the full SHA 540693dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f50d34e - Browse repository at this point
Copy the full SHA f50d34eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.