Updated to latest bootstrap, jquery, filesaver. #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched from glyphicons to bootstrap icons. This will allow us to switch to "vanilla" JS & remove jquery. Hide the import/export accordion until the app is loaded. Use enableCORS, remove individual CORS headers.
which were trying to load local css & js, which does not currently work. Removed isotope library, used bootstrap grid instead. Query product for info & simple page titles. Removed target="_blank" from navbar links.
|
Hi Jason, The UI looks much cleaner. Well done! Q: Is there any reason not to just use the version that is on the local file system? I also put my LEDs on an isolated network, and in many places, people pay for all data transferred (no flat rate internet). |
henrygab
requested changes
Dec 20, 2021
Thanks!
Yes, the local file system static files are not currently being served correctly. See #231 (comment) |
Inlined a few styles to compensate for local static file problem. Fixed info softAPMacAddress label.
henrygab
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The look of the web app didn't change drastically.
Before:
After: