Namespaced awareness #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so that other keys under `data` other than anchor and focus are included like display-related keys name, color, and alphaColor.
…istered on unmount
…or with namespacing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. The commits aren't yet cleaned up for easy review/understanding.
The diff in
useCursor.tsis a little hard to read because there are two changes:newCursorDataonly looks at other awarenesses where theirawarenessPathvalue matches theawarenessPathof this editor.editor.awareness.on('update', () => { ... })code from the useEffect and extracted that into its ownonUpdateso that the useEffect can unregister the handler on cleanup.I also call that
onUpdatehandler one extra time in the useEffect setup. I thought that this solved a case when we render a fresh editor for a type that already has other users' present cursors in the awareness. But I don't think it's working like I want it to, so it may be unnecessary.