Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Restrict shorter peg rounds to Archery tier as per the rules in the new 2025 field classifications. #101

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

jatkinson1000
Copy link
Owner

Due to a lack of specific tests a last minute bug crept in to #46 whereby shorter peg rounds were not restricted to Archery classification , but instead had values returned for all classifications.

This patch rectifies that, and introduces tests explicitly for this that were previously missing.

@jatkinson1000 jatkinson1000 self-assigned this Nov 17, 2024
@jatkinson1000 jatkinson1000 added bug Something isn't working Testing Addition of tests labels Nov 17, 2024
@jatkinson1000 jatkinson1000 merged commit c6264bd into main Nov 17, 2024
15 checks passed
@jatkinson1000 jatkinson1000 deleted the newfield-patch branch November 17, 2024 15:48
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.81%. Comparing base (29e2451) to head (b58b7da).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #101   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files          30       30           
  Lines        1736     1742    +6     
=======================================
+ Hits         1698     1704    +6     
  Misses         38       38           
Files with missing lines Coverage Δ
...utils/classifications/agb_field_classifications.py 100.00% <100.00%> (ø)
...cheryutils/classifications/tests/test_agb_field.py 100.00% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Testing Addition of tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant