Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate score for round and score for passes into two functions #51

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

jatkinson1000
Copy link
Owner

Closes #4

Add score_for_passes function that can be called by score_for_round such that the latter now returns a single number which is more intuitive.

This is a Breaking Change implemented in preparation for first release.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (68043ff) 95.06% compared to head (6916eb1) 95.07%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #51   +/-   ##
=======================================
  Coverage   95.06%   95.07%           
=======================================
  Files          22       22           
  Lines        1216     1218    +2     
=======================================
+ Hits         1156     1158    +2     
  Misses         60       60           
Files Coverage Δ
...tils/classifications/agb_indoor_classifications.py 98.43% <ø> (ø)
.../classifications/agb_old_indoor_classifications.py 97.91% <ø> (ø)
...ils/classifications/agb_outdoor_classifications.py 99.15% <ø> (ø)
archeryutils/handicaps/handicap_equations.py 100.00% <100.00%> (ø)
archeryutils/handicaps/tests/test_handicaps.py 100.00% <ø> (ø)
archeryutils/handicaps/handicap_functions.py 82.74% <83.33%> (ø)

@jatkinson1000
Copy link
Owner Author

Codecov diff is complaining about a line that wasn't hit in previous testing, so OK to merge.

@jatkinson1000 jatkinson1000 merged commit 581fed0 into main Jan 9, 2024
10 of 11 checks passed
@jatkinson1000 jatkinson1000 deleted the round_score_dev branch January 9, 2024 21:23
@jatkinson1000 jatkinson1000 mentioned this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hc_eq.score_for_round should not return a tuple
1 participant