Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle distance and diameter units in a better way #54

Merged
merged 5 commits into from
Jan 27, 2024
Merged

Conversation

jatkinson1000
Copy link
Owner

Closes #53

As raised by @TomHall2020 in #52 this simplifies and improves the method for setting units for distances and diameters.

@jatkinson1000 jatkinson1000 self-assigned this Jan 27, 2024
@jatkinson1000 jatkinson1000 added the enhancement New feature or request label Jan 27, 2024
Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (133abdb) 95.38% compared to head (0ecd135) 95.42%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   95.38%   95.42%   +0.03%     
==========================================
  Files          23       23              
  Lines        1301     1311      +10     
==========================================
+ Hits         1241     1251      +10     
  Misses         60       60              
Files Coverage Δ
archeryutils/__init__.py 100.00% <ø> (ø)
archeryutils/classifications/__init__.py 100.00% <ø> (ø)
...utils/classifications/agb_field_classifications.py 98.50% <ø> (ø)
...tils/classifications/agb_indoor_classifications.py 98.43% <ø> (ø)
.../classifications/agb_old_indoor_classifications.py 97.91% <ø> (ø)
...ils/classifications/agb_outdoor_classifications.py 99.15% <100.00%> (ø)
...cheryutils/classifications/classification_utils.py 90.38% <ø> (ø)
...cheryutils/classifications/tests/test_agb_field.py 100.00% <ø> (ø)
...heryutils/classifications/tests/test_agb_indoor.py 100.00% <ø> (ø)
...utils/classifications/tests/test_agb_old_indoor.py 100.00% <ø> (ø)
... and 11 more

@jatkinson1000 jatkinson1000 merged commit 8271915 into main Jan 27, 2024
11 checks passed
@jatkinson1000 jatkinson1000 deleted the units branch January 27, 2024 19:21
@jatkinson1000 jatkinson1000 mentioned this pull request Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify passing of magnitude and units in the code.
1 participant