Skip to content
This repository has been archived by the owner on Nov 14, 2023. It is now read-only.

Commit

Permalink
Code-review to fix comments and ESlint to get build to complete
Browse files Browse the repository at this point in the history
  • Loading branch information
daudmohamed committed Aug 1, 2023
1 parent ff3bd2b commit 5bc272f
Show file tree
Hide file tree
Showing 13 changed files with 340 additions and 91 deletions.
21 changes: 18 additions & 3 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,24 @@
{
"parser": "@typescript-eslint/parser",
"plugins": [
"@typescript-eslint"
],
"extends": [
"eslint:recommended",
"plugin:@typescript-eslint/recommended",
"next/core-web-vitals",
"prettier",
"plugin:storybook/recommended"
"plugin:storybook/recommended",
"prettier"
],
"rules": {}
"rules": {
"no-unused-vars": "off",
"@typescript-eslint/no-unused-vars": [
"warn", // or "error"
{
"argsIgnorePattern": "^_",
"varsIgnorePattern": "^_",
"caughtErrorsIgnorePattern": "^_"
}
]
}
}
6 changes: 5 additions & 1 deletion app/header.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,12 @@ const Line = ({ className }: { className: string }) => (
/>
</>
)
type BurgerProps = {
active: boolean
setActive: (b: boolean) => void
}

const Burger = ({ active, setActive }: { active: boolean; setActive: (b: boolean) => void }) => (
const Burger = ({ active, setActive }: BurgerProps) => (
<a
role="button"
onClick={() => setActive(!active)}
Expand Down
1 change: 0 additions & 1 deletion app/program/SimpleTalk.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import React from 'react'
import styles from './page.module.css'
import { formatter, prettyFormat, prettyLanguage } from './utils'
import { Session } from '@/app/program/program'
import Link from 'next/link'
Expand Down
1 change: 0 additions & 1 deletion app/program/page.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Session, SessionFormat } from './program'
import styles from './page.module.css'
import { SessionGroup } from './SessionGroup'
import { fetchProgram } from '@/app/program/fetchProgram'
import { Title } from '@/components/title/Title'
Expand Down
1 change: 0 additions & 1 deletion app/theme/page.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
'use client'

import Image from 'next/image'
// @ts-ignore
import AOS from 'aos'
import 'aos/dist/aos.css'
import * as React from 'react'
Expand Down
1 change: 0 additions & 1 deletion app/volunteers/page.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
'use client'

// @ts-ignore
import AOS from 'aos'
import 'aos/dist/aos.css'
import { useEffect } from 'react'
Expand Down
3 changes: 1 addition & 2 deletions components/backgroundSection/BackgroundSection.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@ import React from 'react'

interface BackgroundSectionProps {
/**
* TODO
* Type of section, normal or undefined
* Type of section, based on where it is used (Defines the background image)
*/
type?: 'about'
}
Expand Down
20 changes: 1 addition & 19 deletions components/link/Link.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export const Link = ({ type = 'normal', href, className, children, ...props }: L
return (
<a
className={`text-big-text-color hover:text-hover-text-color ${className}`}
rel="noreferrer noopener"
href={href}
{...props}
>
Expand Down Expand Up @@ -60,22 +61,3 @@ export const Link = ({ type = 'normal', href, className, children, ...props }: L
)
}
}
/*
background-color: var(--normal-text-color);
border-color: transparent;
color: #650729;
button {
background-color: #fff;
border-color: #dbdbdb;
border-width: 1px;
color: #363636;
cursor: pointer;
justify-content: center;
padding: calc(.5em - 1px) 1em;
text-align: center;
white-space: nowrap;
}
*/
1 change: 0 additions & 1 deletion components/section/Section.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import React from 'react'

interface SectionProps {
/**
* TODO
* Type of section, normal or 2 columns section
*/
type?: 'normal' | '2-col'
Expand Down
Loading

0 comments on commit 5bc272f

Please sign in to comment.