Migrate away from Vert.X #175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
surajkumar
approved these changes
Oct 5, 2024
SquidXTV
requested changes
Oct 5, 2024
| @Override | ||
| public void onClose(int i, String s, boolean b) { | ||
| onClose.run(); | ||
| } |
There was a problem hiding this comment.
What is i, s and b? Maybe give them better names and why arent they passed down to onClose like the other methods?
| webSocket.close(); | ||
| if (client != null && !client.isClosed()) { | ||
| try { | ||
| client.closeBlocking(); |
There was a problem hiding this comment.
Maybe add some logging if it succeeded
| import org.apache.logging.log4j.LogManager; | ||
| import org.apache.logging.log4j.Logger; | ||
|
|
||
| public class WebSocketRetryHandler { | ||
| private static final Logger LOGGER = LogManager.getLogger(WebSocketRetryHandler.class); | ||
| private final Vertx vertx; | ||
| private final ScheduledExecutorService scheduler = Executors.newScheduledThreadPool(1); |
There was a problem hiding this comment.
What about Executors#newSingleThreadScheduledExecutor()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #174