Skip to content
This repository has been archived by the owner on Dec 5, 2018. It is now read-only.

Code scanning changes. #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Code scanning changes. #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d717b2
Code scanning version upgrades
ankathur Aug 30, 2018
e61186c
Changing maven-plugin-annotations version
ankathur Aug 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 6 additions & 20 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,6 @@
</developer>
</developers>

<properties>
<maven.version>3.3.9</maven.version>
<release.arguments />
</properties>

<build>
<pluginManagement>
Expand Down Expand Up @@ -219,43 +215,33 @@
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-core</artifactId>
<version>${maven.version}</version>
<version>3.5.0</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-model-builder</artifactId>
<version>${maven.version}</version>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-compat</artifactId>
<version>${maven.version}</version>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can have some impact on which aether API we are using in the plugin.
Did you test the plugin ? Are all the goals working as expected ?

<artifactId>maven-aether-provider</artifactId>
<version>${maven.version}</version>
<version>3.3.9</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not upgrade this one too ? there is a 3.5.4 version on maven central

</dependency>
<dependency>
<groupId>org.apache.maven.plugin-tools</groupId>
<artifactId>maven-plugin-annotations</artifactId>
<version>3.5.1</version>
<version>3.5</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the downgrade from 3.5.1 to 3.5 ?

</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-archiver</artifactId>
<version>3.1.1</version>
<version>3.2.0</version>
</dependency>
<dependency>
<groupId>org.apache.ant</groupId>
<artifactId>ant</artifactId>
<version>1.8.3</version>
<version>1.10.1</version>
</dependency>
<dependency>
<groupId>org.apache.maven.shared</groupId>
<artifactId>maven-common-artifact-filters</artifactId>
<version>1.4</version>
<version>3.0.1</version>
</dependency>
</dependencies>

Expand Down