Update advanced-logger.js in order to comply with Winston configuration #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that you have an error in the configuration of the logger. As a matter of fact, if a configure the logger to have a max size of 1mb you should configure the winston.logger maxsize variable in this way filesize = config.maxsize * 1048576 and not filesize = config.maxsize * 1073741824 (since it is 1000 Mb).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that you have an error in the configuration of the logger. As a matter of fact, if a configure the logger to have a max size of 1mb you should configure the winston.logger maxsize variable in this way filesize = config.maxsize * 1048576 and not filesize = config.maxsize * 1073741824 (since it is 1000 Mb).