Raise incompatible algorithm errors

lib/active_recall.rb

@@ -30,4 +30,6 @@ def self.configuration
   def self.reset
     @configuration = Configuration.new
   end
+
+  class IncompatibleAlgorithmError < StandardError; end
 end

lib/active_recall/algorithms/sm2.rb

@@ -19,6 +19,10 @@ def self.score(box:, easiness_factor:, times_right:, times_wrong:, grade:, curre
       ).score
     end
 
+    def self.type
+      :gradable
+    end
+
     def initialize(box:, easiness_factor:, times_right:, times_wrong:, grade:, current_time: Time.current)
       @box = box
       @easiness_factor = easiness_factor || 2.5

lib/active_recall/models/item.rb

@@ -18,21 +18,33 @@ def self.known(current_time: Time.current)
     end
 
     def score!(grade)
-      update!(
-        algorithm_class.score(**scoring_attributes.merge(grade: grade))
-      ).score
+      if algorithm_class.type == :gradable
+        update!(
+          algorithm_class.score(**scoring_attributes.merge(grade: grade))
+        ).score
+      else
+        raise IncompatibleAlgorithmError, "#{algorithm_class.name} is a not an gradable algorithm, so is not compatible with the #score! method"
+      end
     end
 
     def source
       source_type.constantize.find(source_id)
     end
 
     def right!
-      update!(algorithm_class.right(**scoring_attributes))
+      if algorithm_class.type == :binary
+        update!(algorithm_class.right(**scoring_attributes))
+      else
+        raise IncompatibleAlgorithmError, "#{algorithm_class.name} is not a binary algorithm, so is not compatible with the #right! method"
+      end
     end
 
     def wrong!
-      update!(algorithm_class.wrong(**scoring_attributes))
+      if algorithm_class.type == :binary
+        update!(algorithm_class.wrong(**scoring_attributes))
+      else
+        raise IncompatibleAlgorithmError, "#{algorithm_class.name} is not a binary algorithm, so is not compatible with the #wrong! method"
+      end
     end
 
     private
@@ -46,7 +58,5 @@ def scoring_attributes
         .symbolize_keys
         .slice(*algorithm_class.required_attributes)
     end
-
-    class IncompatibleAlgorithmError < StandardError; end
   end
 end

spec/active_recall/item_methods_spec.rb

@@ -11,25 +11,40 @@
   end
 
   describe "#right_answer_for!" do
-    it "calls right! on the corresponding item" do
-      expect_any_instance_of(ActiveRecall::Item).to receive(:right!).and_call_original
-      user.right_answer_for!(item)
+    it "errors when tried without a binary algorithm" do
+      ActiveRecall.configure do |config|
+        @previous_algorithm_class = config.algorithm_class
+        config.algorithm_class = ActiveRecall::SM2
+      end
+
+      expect { user.right_answer_for!(item) }.to raise_error(ActiveRecall::IncompatibleAlgorithmError)
+
+      ActiveRecall.configure do |config|
+        config.algorithm_class = @previous_algorithm_class
+      end
     end
   end
 
   describe "#wrong_answer_for!" do
-    it "calls wrong! on the corresponding item" do
-      expect_any_instance_of(ActiveRecall::Item).to receive(:wrong!).and_call_original
-      user.wrong_answer_for!(item)
+    it "errors when tried without a binary algorithm" do
+      ActiveRecall.configure do |config|
+        @previous_algorithm_class = config.algorithm_class
+        config.algorithm_class = ActiveRecall::SM2
+      end
+
+      expect { user.wrong_answer_for!(item) }.to raise_error(ActiveRecall::IncompatibleAlgorithmError)
+
+      ActiveRecall.configure do |config|
+        config.algorithm_class = @previous_algorithm_class
+      end
     end
   end
 
-  xdescribe "#score!" do
+  describe "#score!" do
     let(:grade) { 4 }
 
-    it "calls score! on the corresponding item with the correct grade" do
-      expect_any_instance_of(ActiveRecall::Item).to receive(:score!).with(grade).and_call_original
-      user.score!(grade, item)
+    it "errors when tried without a binary algorithm" do
+      expect { user.score!(grade, item) }.to raise_error(ActiveRecall::IncompatibleAlgorithmError)
     end
   end
 end

spec/active_recall_spec.rb

@@ -27,10 +27,17 @@
     context "when overriding the default" do
       before do
         ActiveRecall.configure do |config|
+          @previous_algorithm_class = config.algorithm_class
           config.algorithm_class = ActiveRecall::FibonacciSequence
         end
       end
 
+      after do
+        ActiveRecall.configure do |config|
+          config.algorithm_class = @previous_algorithm_class
+        end
+      end
+
       it "uses the explicitly specified algorithm" do
         allow(ActiveRecall::FibonacciSequence).to receive(:right).and_return({})
         allow(ActiveRecall::LeitnerSystem).to receive(:right)