Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SM-2 algorithm option #25

Merged
merged 8 commits into from
Dec 27, 2023
Merged

Add SM-2 algorithm option #25

merged 8 commits into from
Dec 27, 2023

Conversation

jaysonvirissimo
Copy link
Owner

@jaysonvirissimo jaysonvirissimo commented Dec 21, 2023 •
edited
Loading

TODO:

  • Implement SM-2 algorithm
  • Generator adds migration to persist easiness factor
  • Raise errors when attempting to use scoring methods with incompatible algorithms
  • Update README with SM-2 example
  • Cut new version

Closes #21

jaysonvirissimo
jaysonvirissimo commented Dec 21, 2023
View reviewed changes
lib/active_recall/algorithms/sm2.rb
@times_wrong = times_wrong
@grade = grade
@current_time = current_time
@interval = [1, box].max
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next review should always be tomorrow at the earliest.

jaysonvirissimo
jaysonvirissimo commented Dec 21, 2023
View reviewed changes
lib/active_recall/algorithms/sm2.rb
if @grade >= 3
@box += 1
@times_right += 1
@interval = case @box
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the other SRS algorithms require a box concept, we can re-use it here to avoid having to persist the interval in addition to the easiness factor.

@jaysonvirissimo jaysonvirissimo marked this pull request as ready for review December 24, 2023 05:38
@jaysonvirissimo jaysonvirissimo self-assigned this Dec 24, 2023
@jaysonvirissimo
Copy link
Owner Author

@benjaminhouy, LMK if you have any feedback on this implementation.

@jaysonvirissimo jaysonvirissimo merged commit 9077cd0 into master Dec 27, 2023
9 checks passed
@jaysonvirissimo jaysonvirissimo deleted the add-sm2-algorithm-option branch April 29, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jaysonvirissimo jaysonvirissimo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add SM-2 algorithm option
1 participant
@jaysonvirissimo