Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hardcoded AUTH_USER_MODEL in migrations #677

Closed

Conversation

joeyorlando
Copy link

Hi there 👋

Great project! I wanted to contribute to fixing a "bug" I realized in the migrations. When you set USER_MODEL as such in your settings.py:

PUSH_NOTIFICATIONS_SETTINGS = {
    "USER_MODEL": "user_management.User",
   ...
}

the migrations still create a foreign key reference to the value of AUTH_USER_MODEL.

This PR would update that to use the value of settings.PUSH_NOTIFICATION_SETTINGS["USER_MODEL"]

@joeyorlando
Copy link
Author

It seems like this may be a duplicate of #572 .. but any way one of these can be merged in and released? 😄

@joeyorlando
Copy link
Author

closing in favour of #572

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant