Re-opened PR (#696): Add aioapns version of APNS #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates: - [github.com/asottile/pyupgrade: v2.37.2 → v2.37.3](asottile/pyupgrade@v2.37.2...v2.37.3) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Update tox.ini * Update release.yml
* Update test.yml Fixes failing python 3.6 tests * Update test.yml
* [pre-commit.ci] pre-commit autoupdate (#669) * [pre-commit.ci] pre-commit autoupdate updates: - [github.com/pre-commit/pre-commit-hooks: v4.3.0 → v4.4.0](pre-commit/pre-commit-hooks@v4.3.0...v4.4.0) - [github.com/asottile/pyupgrade: v2.37.3 → v3.10.1](asottile/pyupgrade@v2.37.3...v3.10.1) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: jscarlett <[email protected]>
• Added example code to register WP device • Fixed issue where call to extract UserAgent didn't include UA • Added examples on how to send a Web Push message
Co-authored-by: Ian Later <[email protected]>
* Add WebPush support for Safari * Update webpush.py based on review Declare results variable at the start of the block * Fix typo in warning Co-authored-by: Cuyler Stuwe <[email protected]> * Update README.rst Co-authored-by: James Bligh <[email protected]> * Fix mailto: space * Expanded documentation for Web Push (#558) • Added example code to register WP device • Fixed issue where call to extract UserAgent didn't include UA • Added examples on how to send a Web Push message * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Attempt to fix tests * Update README.rst --------- Co-authored-by: James Bligh <[email protected]> Co-authored-by: Cuyler Stuwe <[email protected]> Co-authored-by: Éloi Rivard <[email protected]> Co-authored-by: Neil Littlejohns <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Add long_description settings to setup.py to address `twine check` errors
Since version python 3.10+ is not supported by `apns2` (because of dependency on `hyper`) we add `aioapns` version of sending APNs notifications. We add installation extra `[APNS_ASYNC]` that installs aioapns and use new version of service if `aioapns` is installed. Tests are also conditional on installed modules/version of python.
* Add FCM v1 API * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add Unit Tests for GCMDeviceAdmin and fix FCM v1 tests * fixes admin test for python 3.6 --------- Co-authored-by: Tim Jahn <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Tim Jahn <[email protected]>
for more information, see https://pre-commit.ci
(fix missing space)
* Remove python 3.6 support. * Remove unsupported code
…ge, add ruff formatting config
to conform with Core metadata specification https://packaging.python.org/en/latest/specifications/core-metadata/#provides-extra-multiple-use
50-Course
changed the title
50-Course
changed the title
|
@50-Course are you guys releasing the new version on PyPI? |
|
Hi @vitorguima, jamaal is a better point of contact in that regard. |
|
@jamaalscarlett : could we get a version released on PyPI? It seems like everything is in place, just need it released. |
|
revisting this... would see if i can hasten this up. i think we would be versioning this at 3.2.0? if possible we can roll this out this weekend or early next week. Given there are only few major changes between 3.1.0 (april) and this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reopens the original PR #696, which was inadvertently closed. It includes the necessary changes for adding the aioapns version of APNS.
I sincerely apologize for the confusion caused by my earlier actions. The changes have been pushed with proper attribution to the original author, @pomali .
Thank you for your understanding.