Fix #744: Bulk messages with aoiapns not working properly

[mikaelengstrom]

Previous version implemented aioapns in a way that made it hang indefinetly. Especially when receiver list contaned a lot of bad tokens.

Having a lot of bad tokens still affects the reliability and transfer speed of notification sets, which is why this fix also deactivate devices for error codes BadDeviceToken and DeviceTokenNotForTopic unlike previous versions.

Tagging @pomali who initially did the aoiapns integration in case you have any feedback.

[mikaelengstrom]

Would be thankful if for example @50-Course could look into this since you managed the last PR by @pomali

[50-Course]

hi @mikaelengstrom. apologies, couldn't make a comment back yesterday - as the notification came in amid few things. i understand the intent behind this change, however, can we have a test suite to ensure this doesn't break things down the line?

[mikaelengstrom]

@50-Course I have now fixed the existing testsuite. In my opinion it is quite excessive already. Overall i have not changed interface that much, the difference should be that some more statuses is setting "inactive" than before. I also implemented APNSException on failures now to keep the async implementation closer to the original apns implementation. I switch from "status" to "message" since when doing bulk message we need to throw one exception and there can be multiple errors. I realize this is a breaking change, but afik this backend have not been released yet.

Regarding the actual issue i tried to resolve (faulty usage of async causing never exiting state on errors) i do not really see how to implement regression tests for that.