Refactor SQL query time calculation to use Django aggregation #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ordered Django model imports alphabetically for better readability. - Refactored `time_spent_on_sql_queries` property in the `Request` model: - Replaced manual summation of `time_taken` with a Django aggregate query. - Used `ExpressionWrapper` to calculate the total time spent on SQL queries by subtracting `start_time` from `end_time`. - Ensured `None` values are handled gracefully using the `Coalesce` function. - Updated relevant test case to reflect the changes. This improves the efficiency and readability of the code."
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…tagymohamed/django-silk into fix/aggregate-sql-query-time
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…tagymohamed/django-silk into fix/aggregate-sql-query-time
|
@albertyw the PR is ready, sorry for the big number of commits and workflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
time_spent_on_sql_queriesproperty in theRequestmodel:time_takenwith a Django aggregate query.This improves the efficiency of the code.