Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated test matrix to test against Django 5.2 explicitly #1441

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

tim-schilling
Copy link
Contributor

Description

Updated test matrix to use Django 5.2

Related Issue

Motivation and Context

Test coverage and the main ci action was broken.

How Has This Been Tested?

It hasn't yet. We'll see how ci does.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the pre-commit run command to format and lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

@tim-schilling tim-schilling mentioned this pull request Jan 23, 2025
11 tasks
@tim-schilling tim-schilling requested a review from ddabble January 23, 2025 12:55
CHANGES.rst Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@tim-schilling
Copy link
Contributor Author

I committed the suggested changes. I included the alpha mention because it may not be clear to others and it doesn't hurt anything to be explicit.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.02%. Comparing base (64cdeb4) to head (f94173e).
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1441      +/-   ##
==========================================
+ Coverage   96.87%   97.02%   +0.15%     
==========================================
  Files          24       24              
  Lines        1470     1479       +9     
  Branches      240      189      -51     
==========================================
+ Hits         1424     1435      +11     
  Misses         25       25              
+ Partials       21       19       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ddabble ddabble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@ddabble ddabble merged commit 8d69847 into jazzband:master Jan 23, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants