-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade python & django #58
Conversation
Hello @jbalogh, hope you are well. I wondered if I could assist with anything else to move this along. |
Hello again @jbalogh. Any updates on this? |
Sorry @ronardcaktus I missed that request but I can probably get it moving. I've set myself as a reviewer to look at it soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also update .github/workflows/ci.yml
? Unfortunately I don't have access to force it to run so we won't be able to see the results because I think it's not currently enabled, but that way when it is enabled it will be up to date...
Done! Thanks for taking a look @diox |
Ah, good news, I can approve test runs. |
Done. Just an FYI, I did not update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can drop .travis.yml
completely while you're at it.
.github/workflows/ci.yml
Outdated
- python: 3.10 | ||
toxenv: py310-3.2.X | ||
- python: 3.10 | ||
toxenv: py310-4.0.X | ||
- python: 3.10 | ||
toxenv: py310-4.2.X |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add quotes around 3.10
, otherwise yaml parses it as 3.1
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Sigh... Looks like we'll have to remove |
Do you mean delete |
Yes, remove them completely, probably replacing them with |
@diox I just disabled the github
Can you please run the jobs? |
Thanks! |
Summary
Python 3.10
Django 4+
django-nose
andflake8
to the latest versions.py
ending from.sh
file because it's deprecatedTest
(I used tox) On the command line, run:
tox
Test result overview