Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix behavior with @BeforeScenario and @AfterScenario #49

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Fix behavior with @BeforeScenario and @AfterScenario #49

merged 2 commits into from
Dec 22, 2023

Conversation

xsmrcek
Copy link

@xsmrcek xsmrcek commented Sep 26, 2023

No description provided.

@xsmrcek xsmrcek marked this pull request as draft September 26, 2023 14:25
@xsmrcek xsmrcek force-pushed the ds/before-after-scenario-fix branch from 2e05a28 to f85ea0e Compare September 26, 2023 14:27
@xsmrcek xsmrcek marked this pull request as ready for review September 26, 2023 18:38
paveljandejsek
paveljandejsek approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@paveljandejsek paveljandejsek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, superb work!

src/main/java/org/jbehavesupport/engine/reporter/StepLoggingReporter.java Outdated Show resolved Hide resolved
src/main/java/org/jbehavesupport/runner/reporter/JUnitStepReporter.java Outdated Show resolved Hide resolved
src/test/java/org/jbehavesupport/runner/story/steps/TestSteps.java Outdated Show resolved Hide resolved
src/test/java/org/jbehavesupport/runner/story/steps/TestSteps.java Outdated Show resolved Hide resolved
@xsmrcek xsmrcek force-pushed the ds/before-after-scenario-fix branch from 7b22ff3 to d0b3cbe Compare September 27, 2023 06:06
@xsmrcek xsmrcek force-pushed the ds/before-after-scenario-fix branch from d0b3cbe to bfa4d85 Compare September 27, 2023 06:49
@paveljandejsek paveljandejsek merged commit 2a6cbc0 into jbehavesupport:master Dec 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakubVychodil JakubVychodil JakubVychodil approved these changes

@paveljandejsek paveljandejsek paveljandejsek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xsmrcek @paveljandejsek @JakubVychodil