Update Docstrings in Visualization Module #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add parameters and their description/type * Add examples Co-authored-by: Maximilian Krahn <[email protected]>
|
Looks great, thank you! 💪 Review:
|
|
Thanks, just did it. I believe the example is now as short as it can be while still showcasing the whole functionality. |
|
Looks good! Can you just resolve the conflicts, please? Then I will merge it 💪 |
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix spelling / too long lines; add hyperlinks; improve explainations
Add type information in signature (s: pd.Series), ...
Improve module docstring at the very top
The other (functional) changes to
scatterplotthat were implemented in #107 (overhauling the function + adding 3D support + adding hover_name argument) will be in a separate PR once this is merged.