Sort meta keys before printing to fix tests broken by Beancount 2.3.6 #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
beancount/beancount#726 (released in Beancount 2.3.6) changed the sort order of posting meta items when converting postings to strings. The meta items were previously printed in sorted order, and now are printed in insertion order. This breaks most beancount-import tests because they determine correctness by comparing transactions' string representations.
This PR introduces
SortedEntryPrinter, which wraps Beancount'sEntryPrinterand restores the previous behavior. It usesSortedEntryPrinterin the two places where tests rely on sort order. This fixes the tests.Fixes #212.