Upgrade Node 15.x to 18.x #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zburatorul
force-pushed
the
Zburatorul-node-ver-upgrade
branch
5 times, most recently
from
ce678f4
to
1d5602f
Compare
* upload-artifact v2 * download-artifact v4.1.7 * upload-artifact v4 * cache v4 * setup-node v4 * setup-python v5 Other changes: * limit beancount version to below 3 * type hinting to pass pytest
Zburatorul
force-pushed
the
Zburatorul-node-ver-upgrade
branch
from
1dcd4f4
to
fcb7bf0
Compare
jbms
approved these changes
Sep 20, 2024
|
Thanks for these fixes. It would be nice to support beancount v3 but that could be done separately. For |
Zburatorul
merged commit 31867ee
into
dependabot/github_actions/dot-github/workflows/actions/download-artifact-4.1.7
20 checks passed
Zburatorul
added a commit
that referenced
this pull request
Sep 21, 2024
…237) * Bump actions/download-artifact from 2 to 4.1.7 in /.github/workflows Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 2 to 4.1.7. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v2...v4.1.7) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * Upgrade the following action versions: (#238) * upload-artifact v2 * download-artifact v4.1.7 * upload-artifact v4 * cache v4 * setup-node v4 * setup-python v5 Other changes: * limit beancount version to below 3 * type hinting to pass pytest Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Eugeniu Plamadeala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds started failing for several reasons including Github action version deprecation, changes to mypy, and beancount 3 getting released.
These are the minimal changes I identified for the workflow to succeed.
Things that will need more work:
We need to decide if we want to take beancount 3 as a dependency or stick with <3. If we move to 3 we need to move from beancount.ingest to beangulp. An additional issue popped when I tried that which is that
journal_editor_test.pywas failing due to the__automatic__tag. Unclear what that has to do with beancount 3 but it is so.There are some other mypy failures I had to suppress related to abstract classes. Threads online provide mixed advice and it seems the consensus is that it may be a mypy issue.