Skip to content

Commit

Permalink
Making MediatR strong-named
Browse files Browse the repository at this point in the history
  • Loading branch information
@jbogard
jbogard committed Nov 16, 2018
1 parent b3b819f commit 30828d0
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 19 deletions.
2 changes: 1 addition & 1 deletion Directory.Build.props
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
<PropertyGroup>
<Authors>Jimmy Bogard</Authors>
<LangVersion>latest</LangVersion>
<VersionPrefix>5.1.0</VersionPrefix>
<VersionPrefix>6.0.0</VersionPrefix>
</PropertyGroup>
</Project>
Binary file added MediatR.snk
View file
Binary file not shown.
2 changes: 1 addition & 1 deletion samples/MediatR.Examples.DryIocZero/MediatR.Examples.DryIocZero.csproj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net45</TargetFramework>
<TargetFramework>net461</TargetFramework>
</PropertyGroup>

<ItemGroup>
Expand Down
6 changes: 3 additions & 3 deletions samples/MediatR.Examples.Ninject/MediatR.Examples.Ninject.csproj
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net451</TargetFramework>
<TargetFramework>net461</TargetFramework>
<AssemblyName>MediatR.Examples.Ninject</AssemblyName>
<OutputType>Exe</OutputType>
<PackageId>MediatR.Examples.Ninject</PackageId>
Expand All @@ -17,7 +17,7 @@
<PackageReference Include="ninject.extensions.conventions" Version="3.3.0" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'net451' ">
<ItemGroup Condition=" '$(TargetFramework)' == 'net461' ">
<Reference Include="System" />
<Reference Include="Microsoft.CSharp" />
</ItemGroup>
Expand Down
14 changes: 3 additions & 11 deletions samples/MediatR.Examples/MediatR.Examples.csproj
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net45;netstandard1.3;netstandard2.0</TargetFrameworks>
<TargetFrameworks>net461;netstandard2.0</TargetFrameworks>
<AssemblyName>MediatR.Examples</AssemblyName>
<PackageId>MediatR.Examples</PackageId>
</PropertyGroup>
Expand All @@ -10,20 +10,12 @@
<ProjectReference Include="..\..\src\MediatR\MediatR.csproj" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'net45' ">
<ItemGroup Condition=" '$(TargetFramework)' == 'net461' ">
<PackageReference Include="System.Linq" Version="4.3.0" />
<Reference Include="System" />
<Reference Include="Microsoft.CSharp" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard1.3' ">
<PackageReference Include="Microsoft.CSharp" Version="4.5.0" />
<PackageReference Include="System.Collections" Version="4.3.0" />
<PackageReference Include="System.Linq" Version="4.3.0" />
<PackageReference Include="System.Runtime" Version="4.3.0" />
<PackageReference Include="System.Threading" Version="4.3.0" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0'">
<PackageReference Include="Microsoft.CSharp" Version="4.5.0" />
</ItemGroup>
Expand Down
8 changes: 5 additions & 3 deletions src/MediatR/MediatR.csproj
View file
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<Description>Simple, unambitious mediator implementation in .NET</Description>
<Copyright>Copyright Jimmy Bogard</Copyright>
<TargetFrameworks>net45;netstandard1.3;netstandard2.0</TargetFrameworks>
<TargetFrameworks>net461;netstandard2.0</TargetFrameworks>
<AssemblyName>MediatR</AssemblyName>
<PackageId>MediatR</PackageId>
<PackageTags>mediator;request;response;queries;commands;notifications</PackageTags>
Expand All @@ -12,9 +12,11 @@
<PackageLicenseUrl>https://github.com/jbogard/MediatR/blob/master/LICENSE</PackageLicenseUrl>
<RepositoryType>git</RepositoryType>
<RepositoryUrl>git://github.com/jbogard/mediatr</RepositoryUrl>
<SignAssembly>true</SignAssembly>
<AssemblyOriginatorKeyFile>..\..\MediatR.snk</AssemblyOriginatorKeyFile>
</PropertyGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'net45' ">
<ItemGroup Condition=" '$(TargetFramework)' == 'net461' ">
<Reference Include="System" />
<Reference Include="Microsoft.CSharp" />
</ItemGroup>
Expand Down

9 comments on commit 30828d0

@fuzzzerd
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove netstandard1.3? Why not leave that as a target?

@jbogard
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I don't wan't to support it, it adds to the overall build and IDE load time for a few platforms with minuscule install base compared to netstandard2.0.

@fuzzzerd
Copy link

@fuzzzerd fuzzzerd commented on 30828d0 Dec 11, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the response. It didn't seem like there were many dependencies for 1.3, but build and load time were things I didn't consider.

@jbogard
Copy link
Owner Author

@jbogard jbogard commented on 30828d0 Dec 11, 2018 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fuzzzerd
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Platform wise? Not at the moment. I'm mostly looking at maximizing my deployable base. Upgrading to NET Standard 2.0 isn't out of the question for me though, since I don't currently have a limitation on it.

@jbogard
Copy link
Owner Author

@jbogard jbogard commented on 30828d0 Dec 11, 2018 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fuzzzerd
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some libraries on NuGet and GitHub; though in the context of my use of MediatR its for an internal application that will see many small installations on various configurations.

@jbogard
Copy link
Owner Author

@jbogard jbogard commented on 30828d0 Dec 11, 2018 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fuzzzerd
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Was just trying to understand the reasoning.

Please sign in to comment.