Merge pmd-7-pmd7 branch into master #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deprecated and removed rules. There are also rules with alternatives, so it is probably better to check which ones can be replaced by the new alternative rules.
…in pmd-sonar plugin
…Short" to test pmd-7.0 with kotlin in pmd-sonar plugin; upped some dependencies
…directory; to be able to run it next to pmd(6) in Sonar
Pmd 7 pmd7
…nar-pmd7-plugin back to sonar-pmd-plugin to avoid merge issues in future
- correct rule definitions for pmd7
…330 - pmd7 processFiles api change
# Conflicts: # docs/RULES.md # integration-test/pom.xml # pom.xml
…330, upped maven wrapper to 3.8.4, made Integration Tests more robust
Doing so, migration to PMD7 compatible sonar-pmd plugin will keep the mapping to existing SonarQube issues, plus the PMD7 plugin is recognized as a new version of previous PMD6 based `pmd` plugin.
…narsource plugins have java 17 compiled classes.
Pmd 7 pmd7 merge master
|
stokpop
requested changes
Feb 24, 2025
| <priority>MAJOR</priority> | ||
| <parameters/> | ||
| </rule> | ||
| <!-- <rule>--> |
There was a problem hiding this comment.
should we remove these instead of commenting out?
| <priority>MAJOR</priority> | ||
| <parameters/> | ||
| </rule> | ||
| <!-- <rule>--> |
| <priority>MAJOR</priority> | ||
| <parameters/> | ||
| </rule> | ||
| <!-- <rule>--> |
| <priority>MAJOR</priority> | ||
| <parameters/> | ||
| </rule> | ||
| <!-- <rule>--> |
| <priority>CRITICAL</priority> | ||
| <parameters/> | ||
| </rule> | ||
| <!-- <rule>--> |
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * SonarQube PMD Plugin | |||
| * SonarQube PMD7 Plugin | |||
There was a problem hiding this comment.
should we use PMD7 here? It is still the SonarQube PMD plugin... maybe for 8+ in future
| } | ||
| } | ||
|
|
||
| // @Override |
| <txt>min</txt> | ||
| </prop> | ||
| </chc> | ||
| <!-- <chc>--> |
| <txt>h</txt> | ||
| </prop> | ||
| </chc> | ||
| <!-- NOTE: the following rule has been removed in pmd-7 --> |
There was a problem hiding this comment.
remove? (and some more commented out rules below)
| "UseAssertNullInsteadOfAssertTrue", | ||
| "SimplifyBooleanAssertion", | ||
| "UseAssertTrueInsteadOfAssertEquals", | ||
| //"UseAssertEqualsInsteadOfAssertTrue", // 5 rules have been removed in pmd-7 |
|
Created issue #495 to deal with your remarks. Will be in a follow-up minor releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge for release 4.0.0 (pmd7-release)