[LOGMGR-350] Avoid TCCL when configuring the log manager #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay on this. I need to think how this will work in WildFly. For the integration work I created a new JBoss Module which would somehow need to be exposed on the same class path to pick up the services. |
jamezp
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The services were previously located by looking at the TCCL rather than class loader which loaded the log manager itself. This is normally the system (i.e. application) class loader, but it could be an agent class loader or the bootstrap class loader in certain circumstances.
One result of this behavior is that when the TCCL is not the same as the system class loader, logging can be configured twice: once by Quarkus and once using the default configuration (see elastic/apm-agent-java#3563). Changing to avoid the TCCL causes the behavior to become stable and predictable.