Added initial bats tests and github action set up #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spyrkob
reviewed
Sep 27, 2021
spyrkob
reviewed
Sep 27, 2021
|
Feedback on the review:
|
spyrkob
reviewed
Sep 28, 2021
| @@ -46,4 +46,4 @@ run_ssh "podman exec \ | |||
| -e PULL_REQUEST_PROCESSOR_HOME="${PULL_REQUEST_PROCESSOR_HOME}" \ | |||
| -e VERSION="${VERSION}" \ | |||
| -e COMPONENT_UPGRADE_LOGGER="${COMPONENT_UPGRADE_LOGGER}" \ | |||
| -ti ${CONTAINER_NAME} '${BUILD_SCRIPT}' ${@}" | |||
| -ti ${CONTAINER_NAME} '${BUILD_SCRIPT}' $*" | |||
There was a problem hiding this comment.
I think it should be OK, but @rpelisse could you confirm this?
|
Thanks @gaol! I think running shellcheck with |
rpelisse
requested changes
Nov 17, 2021
| @@ -46,4 +46,4 @@ run_ssh "podman exec \ | |||
| -e PULL_REQUEST_PROCESSOR_HOME="${PULL_REQUEST_PROCESSOR_HOME}" \ | |||
| -e VERSION="${VERSION}" \ | |||
| -e COMPONENT_UPGRADE_LOGGER="${COMPONENT_UPGRADE_LOGGER}" \ | |||
| -ti ${CONTAINER_NAME} '${BUILD_SCRIPT}' ${@}" | |||
| -ti ${CONTAINER_NAME} '${BUILD_SCRIPT}' $*" | |||
| done | ||
| exit 1 | ||
| fi | ||
| echo 'Done - PASSED' |
There was a problem hiding this comment.
@gaol There seems to be quite a lot of code duplication from Harmonia's testsuite... I wonder if it would no be cleaner to have Jenkins checkout Harmonia inside the Hera folder and reuse the stuff... WDTK?
|
@gaol where are we on this PR? It seems to have gone stale, can you rebase and update? |
|
Ah, it must had been lost in my list 😁 will update it soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to add initial bats tests for Hera and set up github action CI.
tests/tests-common.sh- based on the one in harmoniatests/tests-suite.sh- based on the one in harmonia