Add projects and components for validation into the config file #48
Conversation
| private void validateParticipantProjects() throws ConfigException { | ||
| for (Participant participant : participants) { | ||
| for (Project project : participant.projects) { | ||
| if (!availableProjects.containsKey(project.project)) { |
There was a problem hiding this comment.
Maybe we should do case-insensitive string comparison. I believe JQL is case insensitive as well
| } | ||
|
|
||
| Set<String> availableComponents = availableProjects.get(project.project); | ||
| if (!availableComponents.containsAll(project.components)) { |
|
|
||
| public record Participation(@JsonProperty(required = true) int maxIssues) { | ||
| public static class ConfigException extends Exception { |
There was a problem hiding this comment.
I am not sure, if we need a custom exception here.
| public Project(@JsonProperty(required = true) String project, @JsonProperty(required = true) Set<String> components, | ||
| @JsonProperty(required = true) int maxIssues) { | ||
| this(project, components, new Participation(maxIssues)); | ||
| public void validate() throws ConfigException { |
There was a problem hiding this comment.
I would probably keep the config just for config and validation in a different file or directly in LotteryConfigProducer could have this method as private.
| @@ -1,3 +1,3 @@ | |||
| camel.component.jira.jira-url=https://issues.redhat.com/ | |||
| %test.jira-issue-lottery.access-token=ignored | |||
| jira-issue-lottery.config-file-repo=https://github.com/The-Huginn/jira-issue-lottery | |||
There was a problem hiding this comment.
I am not sure about this, perhaps each of us should keep this in .env file and mention this in readme
There was a problem hiding this comment.
Should I create a new issue for that? Then I can add a new commit to this PR and mention both issues.
There was a problem hiding this comment.
I guess so, but there is that one test I commented below, that would need to be adjusted as well, keep that in mind then. However, I do not think there are any particular test fetching a config file anyways, so might be some arbitrary value, for example jboss-set even if the file doesn't exist here.
| @@ -222,7 +252,8 @@ public void testAppendingRepositoryForUnsubcription() throws Exception { | |||
| List<Mail> sent = mailbox.getMailsSentTo(email); | |||
| assertEquals(1, sent.size()); | |||
| // Check directly for this URL as we know it is valid one. Using templates might result in a corrupted URL overall | |||
| assertTrue(sent.get(0).getText().contains("https://github.com/The-Huginn/jira-issue-lottery/blob/main/.github/jira-issue-lottery.yml")); | |||
There was a problem hiding this comment.
this doesn't seem right, as this is a single test with concrete value, with the intention of making sure a valid link is generated
xjusko
force-pushed
the
config-project-validation
branch
from
45d7965
to
e400ad9
Compare
|
resolves #49 |
xjusko
force-pushed
the
config-project-validation
branch
2 times, most recently
from
13b9c51
to
7ac7fd0
Compare
…rties to .env file and set a default for testing.
xjusko
force-pushed
the
config-project-validation
branch
from
7ac7fd0
to
2c11173
Compare
|
Thanks for your help @xjusko . After some conversations we have decided to move forward with a different approach. |
resolves #30