Reduce code duplication in molecule scenarios prepare phase

molecule/account/prepare.yml

@@ -4,13 +4,5 @@
   gather_facts: yes
   tasks:
 
-    - name: "Display Ansible version"
-      ansible.builtin.debug:
-        msg: "Ansible version is  {{ ansible_version.full }}"
-
-    - name: "Install sudo if user is root"
-      ansible.builtin.yum:
-        name: sudo
-        state: present
-      when:
-        - ansible_user_id == "root"
+    - name: "Include common prepare tasks"
+      ansible.builtin.include_tasks: ../prepare.yml

molecule/aphrodite/prepare.yml

@@ -6,34 +6,19 @@
     - vars.yml
   tasks:
 
-    - name: Display Ansible version
-      ansible.builtin.debug:
-        msg: "Ansible version is  {{ ansible_version.full }}"
-
-    - name: "Install sudo if user is root"
-      ansible.builtin.yum:
-        name: sudo
-        state: present
-      when:
-        - ansible_user_id == "root"
-    - name: Add the user jenkins
-      ansible.builtin.user:
-        name: jenkins
-
-    - name: Creates directory
-      become: yes
-      ansible.builtin.file:
-        path: /opt/tools
-        state: directory
-        owner: jenkins
-        group: jenkins
-        mode: 0644
+    - name: "Include common prepare tasks"
+      ansible.builtin.include_tasks: ../prepare.yml
+      vars:
+        users:
+          - "{{ aphrodite_user }}"
+        dirs:
+          - { path: /opt/tools, owner: "{{ aphrodite_user }}", group: "{{ aphrodite_user }}" }
 
     - name: "Deploy aphrodite configuration to {{ aphrodite.path }}"
       become: yes
       ansible.builtin.template:
         src: "../../roles/aphrodite/templates/aphrodite.json.j2"
         dest: "{{ aphrodite.path }}"
-        owner: jenkins
-        group: jenkins
+        owner: "{{ aphrodite_user }}"
+        group: "{{ aphrodite_user }}"
         mode: 0644

molecule/aphrodite/vars.yml

@@ -1,4 +1,5 @@
 ---
+aphrodite_user: jenkins
 aphrodite:
   trackers:
     bugzilla:

molecule/bashrc/prepare.yml

@@ -4,13 +4,5 @@
   gather_facts: yes
   tasks:
 
-    - name: Display Ansible version
-      ansible.builtin.debug:
-        msg: "Ansible version is  {{ ansible_version.full }}"
-
-    - name: "Install sudo if user is root"
-      ansible.builtin.yum:
-        name: sudo
-        state: present
-      when:
-        - ansible_user_id == "root"
+    - name: "Include common prepare tasks"
+      ansible.builtin.include_tasks: ../prepare.yml

molecule/cron/prepare.yml

@@ -6,22 +6,10 @@
     - vars.yml
   tasks:
 
-    - name: Display Ansible version
-      ansible.builtin.debug:
-        msg: "Ansible version is  {{ ansible_version.full }}"
-
-    - name: "Install sudo if user is root"
-      ansible.builtin.yum:
-        name: sudo
-        state: present
-      when:
-        - ansible_user_id == "root"
-
-    - name: Creates directory
-      become: yes
-      ansible.builtin.file:
-        path: /opt/tools
-        state: directory
-        owner: root
-        group: root
-        mode: 0745
+    - name: "Include common prepare tasks"
+      ansible.builtin.include_tasks: ../prepare.yml
+      vars:
+        users:
+          - "{{ aphrodite_user }}"
+        dirs:
+          - { path: '/opt/tools', mode: '0745' }

molecule/fast_yum_install/prepare.yml

@@ -4,13 +4,5 @@
   gather_facts: yes
   tasks:
 
-    - name: Display Ansible version
-      ansible.builtin.debug:
-        msg: "Ansible version is  {{ ansible_version.full }}"
-
-    - name: "Install sudo if user is root"
-      ansible.builtin.yum:
-        name: sudo
-        state: present
-      when:
-        - ansible_user_id == "root"
+    - name: "Include common prepare tasks"
+      ansible.builtin.include_tasks: ../prepare.yml

molecule/git/prepare.yml

@@ -6,27 +6,10 @@
     - vars.yml
   tasks:
 
-    - name: Display Ansible version
-      ansible.builtin.debug:
-        msg: "Ansible version is  {{ ansible_version.full }}"
-
-    - name: "Install sudo if user is root"
-      ansible.builtin.yum:
-        name: sudo
-        state: present
-      when:
-        - ansible_user_id == "root"
-
-    - name: Add the user jenkins
-      become: yes
-      ansible.builtin.user:
-        name: jenkins
-
-    - name: Creates directory
-      become: yes
-      ansible.builtin.file:
-        path: /home/jenkins
-        state: directory
-        owner: jenkins
-        group: jenkins
-        mode: 0644
+    - name: "Include common prepare tasks"
+      ansible.builtin.include_tasks: ../prepare.yml
+      vars:
+        users:
+          - "{{ git_user }}"
+        dirs:
+          - { path: /home/jenkins, owner: "{{ git_user }}", group: "{{ git_user }}" }

molecule/git/vars.yml

@@ -1,4 +1,5 @@
 ---
+git_user: jenkins
 git:
   ssl:
     verify: false
@@ -10,4 +11,4 @@ git:
     - user: jenkins
       email: [email protected]
       name: "JBoss SET"
-      home: "/home/jenkins/"
+      home: "/home/jenkins/"

molecule/hosts/prepare.yml

@@ -5,31 +5,13 @@
   vars_files:
     - vars.yml
   tasks:
-    - name: Display Ansible version
-      ansible.builtin.debug:
-        msg: "Ansible version is  {{ ansible_version.full }}"
-
-    - name: "Install sudo if user is root"
-      ansible.builtin.yum:
-        name: sudo
-        state: present
-      when:
-        - ansible_user_id == "root"
+    - name: "Include common prepare tasks"
+      ansible.builtin.include_tasks: ../prepare.yml
+      vars:
+        dirs:
+          - { path: /etc/fake_hosts, state: touch, mode: 0644 }
+          - { path: /etc/real_hosts, state: touch, mode: 0644 }
 
     - name: "Include fast_yum_install"
       ansible.builtin.include_role:
         name: "fast_yum_install"
-
-    - name: Creates /etc/fake_hosts directory
-      become: yes
-      ansible.builtin.file:
-        path: /etc/fake_hosts
-        state: touch
-        mode: 0644
-
-    - name: Creates /etc/real_hosts directory
-      become: yes
-      ansible.builtin.file:
-        path: /etc/real_hosts
-        state: touch
-        mode: 0644

molecule/java/prepare.yml

@@ -5,16 +5,8 @@
   vars_files:
     - vars.yml
   tasks:
-    - name: Display Ansible version
-      ansible.builtin.debug:
-        msg: "Ansible version is  {{ ansible_version.full }}"
-
-    - name: "Install sudo if user is root"
-      ansible.builtin.yum:
-        name: sudo
-        state: present
-      when:
-        - ansible_user_id == "root"
+    - name: "Include common prepare tasks"
+      ansible.builtin.include_tasks: ../prepare.yml
 
     - ansible.builtin.assert:
         that:

molecule/kdump/prepare.yml

@@ -4,13 +4,5 @@
   gather_facts: yes
   tasks:
 
-    - name: Display Ansible version
-      ansible.builtin.debug:
-        msg: "Ansible version is  {{ ansible_version.full }}"
-
-    - name: "Install sudo if user is root"
-      ansible.builtin.yum:
-        name: sudo
-        state: present
-      when:
-        - ansible_user_id == "root"
+    - name: "Include common prepare tasks"
+      ansible.builtin.include_tasks: ../prepare.yml

molecule/motd/prepare.yml

@@ -6,27 +6,22 @@
     - vars.yml
   tasks:
 
-    - name: Display Ansible version
-      ansible.builtin.debug:
-        msg: "Ansible version is  {{ ansible_version.full }}"
+    - name: "Include common prepare tasks"
+      ansible.builtin.include_tasks: ../prepare.yml
 
-    - name: "Install sudo if user is root"
-      ansible.builtin.yum:
-        name: sudo
-        state: present
-      when:
-        - ansible_user_id == "root"
-
-    - ansible.builtin.assert:
+    - name: "Check that path to motd file has been defined"
+      ansible.builtin.assert:
         that:
           - motd_path is defined
         quiet: true
 
-    - ansible.builtin.stat:
+    - name: "Load metadata on {{ motd_path }}"
+      ansible.builtin.stat:
         path: "{{ motd_path }}"
       register: file_details
 
-    - ansible.builtin.assert:
+    - name: "Ensure that {{ motd_path }} exists."
+      ansible.builtin.assert:
         that:
           - file_details is defined
           - file_details.stat is defined

molecule/netrc/prepare.yml

@@ -5,26 +5,11 @@
   vars_files:
     - vars.yml
   tasks:
-    - name: Display Ansible version
-      ansible.builtin.debug:
-        msg: "Ansible version is  {{ ansible_version.full }}"
 
-    - name: "Install sudo if user is root"
-      ansible.builtin.yum:
-        name: sudo
-        state: present
-      when:
-        - ansible_user_id == "root"
-
-    - name: Add the user jenkins
-      ansible.builtin.user:
-        name: jenkins
-
-    - name: Creates directory
-      become: yes
-      ansible.builtin.file:
-        path: /home/jenkins
-        state: directory
-        owner: jenkins
-        group: jenkins
-        mode: 0644
+    - name: "Include common prepare tasks"
+      ansible.builtin.include_tasks: ../prepare.yml
+      vars:
+        users:
+          - "{{ user_name }}"
+        dirs:
+          - { path: "/home/{{ user_name }}", owner: "{{ user_name }}", group: "{{ user_name }}" }

molecule/prepare.yml

@@ -1,8 +1,34 @@
 ---
-- name: Prepare
-  hosts: all
-  tasks:
+- name: "Display Ansible version"
+  ansible.builtin.debug:
+    msg: "Ansible version is  {{ ansible_version.full }}"
 
-    - name: Display Ansible version
-      ansible.builtin.debug:
-        msg: "Ansible version is {{ ansible_version.full }}"
+- name: "Install sudo if user is root"
+  ansible.builtin.yum:
+    name: sudo
+    state: present
+  when:
+    - ansible_user_id == "root"
+
+- name: Add the user "{{ user }}"
+  ansible.builtin.user:
+    name: "{{ user }}"
+  when:
+    - users is defined and users | length > 0
+  loop: "{{ users }}"
+  loop_control:
+    loop_var: user
+
+- name: "Creates directory"
+  become: yes
+  ansible.builtin.file:
+    path: "{{ dir.path }}"
+    state: "{{ dir.state | default('directory') }}"
+    owner: "{{ dir.owner | default('root') }}"
+    group: "{{ dir.group | default('root') }}"
+    mode: "{{ dir.mode | default('0644') }}"
+  when:
+    - dirs is defined and dirs | length > 0
+  loop: "{{ dirs }}"
+  loop_control:
+    loop_var: dir

molecule/qualys_fix/prepare.yml

@@ -3,20 +3,11 @@
   hosts: all
   gather_facts: yes
   tasks:
-    - name: Display Ansible version
-      ansible.builtin.debug:
-        msg: "Ansible version is  {{ ansible_version.full }}"
 
-    - name: "Install sudo if user is root"
-      ansible.builtin.yum:
-        name: sudo
-        state: present
-      when:
-        - ansible_user_id == "root"
-
-    - name: Creates directory
-      become: yes
-      ansible.builtin.file:
-        path: /root/.ansible/roles/infosec.qualys-cloud-agent/tasks/
-        state: directory
-        mode: 0644
+    - name: "Include common prepare tasks"
+      ansible.builtin.include_tasks: ../prepare.yml
+      vars:
+        users:
+          - "{{ user_name }}"
+        dirs:
+          - { path: "/root/.ansible/roles/infosec.qualys-cloud-agent/tasks/" }

molecule/vault/converge.yml

@@ -4,6 +4,9 @@
   vars_files:
     - vars.yml
   tasks:
+    - name: "Ensure scenario can be run in this execution context."
+      ansible.builtin.include_tasks: is_scenario_enabled.yml
+
     - name: "Include vault tasks"
       ansible.builtin.include_tasks: vault.yml
       when: