Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SWITCHYARD-2976 - update to org.slf4j reference #645

Merged
merged 1 commit into from
Nov 30, 2016
Merged

SWITCHYARD-2976 - update to org.slf4j reference #645

merged 1 commit into from
Nov 30, 2016

Conversation

bfitzpat
Copy link
Member

No description provided.

@bfitzpat
Copy link
Member Author

@lhein or @apupier can you give this a quick once-over - it's for a RPM issue that doesn't show up elsewhere, so was requested from the Dev Tools team.

@nickboldt
Copy link
Contributor

nickboldt commented Nov 30, 2016 •
edited
Loading

+1, looks reasonable... but you don't actually use slf4j, right? So I would suggest merging #644 instead.

@bfitzpat
Copy link
Member Author

We just removed the slf4j reference all together. Everything builds. All tests pass. Smoke test seems ok.

@bfitzpat
Copy link
Member Author

Which is apparently exactly what #644 did. Go figure. Thanks Nick.

@nickboldt
Copy link
Contributor

cool. so it's approved. can we merge it?

@bfitzpat bfitzpat merged commit 7f364c0 into jboss-switchyard:master Nov 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhein lhein lhein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bfitzpat @nickboldt @lhein