JBDS-3598 use git clone instead of git archive #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the sources zip
nickboldt
changed the title
|
Won't this mean the full history of the repo is included ? That is going to make several hundred megabytes difference for bigger repos. I would say either find a way to build for users without the timestsamp check via git or perform a shallow clone so you only get that exact source revision. Mind you - if you do a shallow clone, egit will have some issues with it. |
|
Tried a shallow clone. Didn't work. Mvn still complained. Maybe I need a flag to use clone for jbdevstudio-product, and archive for all other jbosstools-* projects. |
|
i really don't think a full git clone makes any sense for any of this. Lets fix the build to allow for doing it without timestamp or just tell users to run a git init first - would that not work ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JBDS-3598 use git clone instead of git archive so that .git folder is included in the sources zip