Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move requirements to setup.py #60

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Move requirements to setup.py #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b210e8
move requirements to setup.py
retkiewi Jun 14, 2024
c338e04
update min required numpy version
retkiewi Jun 14, 2024
cbdda21
update min required scipy version
retkiewi Jun 14, 2024
409b1cc
update min required versions for python 3.8 compatibility
retkiewi Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1 @@
Cython
numpy
scipy
matplotlib
mpmath
pandas
seaborn
numba
isort
flake8
flake8-isort
-e .
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently this results in an error on windows since the setup.py tries to compile cython. Adding installation variants should solve this.

18 changes: 15 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import os
from setuptools import setup, find_packages, Extension

from setuptools import Extension, setup
from setuptools.command.build_ext import build_ext as _build_ext

try:
Expand Down Expand Up @@ -69,8 +70,19 @@ def no_cythonize(extensions, **_ignore):
else:
extensions = no_cythonize(extensions)

with open("requirements.txt") as fp:
install_requires = fp.read().strip().split("\n")
install_requires = [
"Cython>=3.0.10",
"numpy>=1.24.4",
"scipy>=1.10.1",
"matplotlib>=3.7.5",
"mpmath>=1.3.0",
"pandas>=2.0.3",
"seaborn>=0.13.2",
"numba>=0.58.1",
"isort>=5.13.2",
"flake8>=7.0.0",
"flake8-isort>=6.1.1",
]

setup(
cmdclass={"build_ext": build_ext},
Expand Down